You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2013/11/07 00:14:25 UTC
[Bug 55751] New: Description of filesmatch textfile attribute
behavior is wrong
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
Bug ID: 55751
Summary: Description of filesmatch textfile attribute behavior
is wrong
Product: Ant
Version: 1.9.2
Hardware: PC
OS: Mac OS X 10.4
Status: NEW
Severity: normal
Priority: P2
Component: Documentation
Assignee: notifications@ant.apache.org
Reporter: fadookie@gmail.com
Created attachment 31018
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31018&action=edit
File with unix linebreaks
In the documentation for the filesmatch condition at
https://ant.apache.org/manual/Tasks/conditions.html#filesmatch
It says the following regarding the textfile attribute:
"Whether to ignore line endings when comparing files; defaults to false, while
true triggers a binary comparison. Since Ant 1.7"
This is wrong based on my empirical testing of ant 1.9.2. I believe when
textfile is set to false, it performs a binary comparison. When it's set to
true, it appears to ignore newlines. This makes more sense given the name of
the attribute.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55751] Description of filesmatch textfile attribute behavior is
wrong
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
--- Comment #1 from Eliot Lash <fa...@gmail.com> ---
Created attachment 31019
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31019&action=edit
File with windows linebreaks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55751] Description of filesmatch textfile attribute behavior is
wrong
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
--- Comment #2 from Eliot Lash <fa...@gmail.com> ---
Created attachment 31020
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31020&action=edit
Ant project with test case
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55751] Description of filesmatch textfile attribute behavior is
wrong
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
Eliot Lash <fa...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|Macintosh |All
OS| |All
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55751] Description of filesmatch textfile attribute behavior is
wrong
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
Eliot Lash <fa...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fadookie@gmail.com
Hardware|PC |Macintosh
OS|Mac OS X 10.4 |Mac OS X 10.9
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55751] Description of filesmatch textfile attribute behavior is
wrong
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
--- Comment #3 from Eliot Lash <fa...@gmail.com> ---
Comment on attachment 31020
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31020
Ant project with test case
><project name="filesmatchTest" basedir="." default="test-text">
> <target name="test-text">
> <condition property="filesMatchTextfileTrue" value="true" else="false">
> <filesmatch file1="file1" file2="file2" textfile="true"/>
> </condition>
>
> <condition property="filesMatchTextfileFalse" value="true" else="false">
> <filesmatch file1="file1" file2="file2" textfile="false"/>
> </condition>
>
> <echo message="filesMatchTextfileTrue? ${filesMatchTextfileTrue}${line.separator}filesMatchTextfileFalse? ${filesMatchTextfileFalse}" level="info" />
> </target>
></project>
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55751] Description of filesmatch textfile attribute behavior is
wrong
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55751
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Stefan Bodewig <bo...@apache.org> ---
yes, you are correct. textfile="false" means binary comparison.
svn revision 1539547
--
You are receiving this mail because:
You are the assignee for the bug.