You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by dw...@apache.org on 2008/06/27 21:21:51 UTC
svn commit: r672362 - in
/geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper:
AmqJMSMessageHelper.java JMSMessageHelperFactory.java
Author: dwoods
Date: Fri Jun 27 12:21:51 2008
New Revision: 672362
URL: http://svn.apache.org/viewvc?rev=672362&view=rev
Log:
GERONIMO-3983 upgrade applied patch to work with SLF4J
Modified:
geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java
geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java
Modified: geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java?rev=672362&r1=672361&r2=672362&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java (original)
+++ geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java Fri Jun 27 12:21:51 2008
@@ -127,7 +127,7 @@
stat.setQueueSize(proxy.getQueueSize());
} catch (Exception ex) {
// ignoring the exception
- log.error(ex);
+ log.error("Failed to get ActiveMQ stats", ex);
}
return stat;
}
@@ -144,7 +144,7 @@
BrokerServiceGBeanImpl ref = (BrokerServiceGBeanImpl) kernel.getGBean(BrokerServiceGBeanImpl.class);
brokerName = ref.getBrokerName();
} catch (Exception e) {
- log.equals(e);
+ log.error("Failed to get broker name", e);
}
return brokerName;
}
Modified: geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java?rev=672362&r1=672361&r2=672362&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java (original)
+++ geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java Fri Jun 27 12:21:51 2008
@@ -56,11 +56,11 @@
.forName("org.apache.geronimo.console.jmsmanager.helper.AmqJMSMessageHelper");
messageHelper = (JMSMessageHelper) class_.newInstance();
} catch (IllegalAccessException e) {
- log.error(e);
+ log.error("Failed to load class", e);
} catch (InstantiationException e) {
- log.error(e);
+ log.error("Failed to load class", e);
} catch (ClassNotFoundException e) {
- log.error(e);
+ log.error("Failed to load class", e);
}
}
if(messageHelper == null){