You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Alan M. Carroll (Created) (JIRA)" <ji...@apache.org> on 2011/11/15 00:05:51 UTC

[jira] [Created] (TS-1022) LogEntryHeader is a serialized structure but uses vague types.

LogEntryHeader is a serialized structure but uses vague types.
--------------------------------------------------------------

                 Key: TS-1022
                 URL: https://issues.apache.org/jira/browse/TS-1022
             Project: Traffic Server
          Issue Type: Bug
          Components: Logging
    Affects Versions: 3.1.0
            Reporter: Alan M. Carroll
            Assignee: Alan M. Carroll
            Priority: Minor
             Fix For: 3.1.2


LogEntryHeader in proxy/logging/LogBuffer.h uses the type "long" and "unsigned" even though is used directly as serialized data. This means (among other things) that binary logs have different formats depending on whether ATS was built in 32 bit mode or 64 bit mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (TS-1022) LogEntryHeader is a serialized structure but uses vague types.

Posted by "Alan M. Carroll (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan M. Carroll resolved TS-1022.
---------------------------------

    Resolution: Fixed

Changed LogBufferHeader and LogBufferEntry to use size specific types. Should should make the data more portable.

r1204112
                
> LogEntryHeader is a serialized structure but uses vague types.
> --------------------------------------------------------------
>
>                 Key: TS-1022
>                 URL: https://issues.apache.org/jira/browse/TS-1022
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 3.1.0
>            Reporter: Alan M. Carroll
>            Assignee: Alan M. Carroll
>            Priority: Minor
>             Fix For: 3.1.2
>
>
> LogEntryHeader in proxy/logging/LogBuffer.h uses the type "long" and "unsigned" even though is used directly as serialized data. This means (among other things) that binary logs have different formats depending on whether ATS was built in 32 bit mode or 64 bit mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (TS-1022) LogEntryHeader is a serialized structure but uses vague types.

Posted by "Alan M. Carroll (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153641#comment-13153641 ] 

Alan M. Carroll edited comment on TS-1022 at 11/20/11 1:53 AM:
---------------------------------------------------------------

Changed LogBufferHeader and LogEntryHeader to use size specific types. Should should make the data more portable.

r1204112
                
      was (Author: amc):
    Changed LogBufferHeader and LogBufferEntry to use size specific types. Should should make the data more portable.

r1204112
                  
> LogEntryHeader is a serialized structure but uses vague types.
> --------------------------------------------------------------
>
>                 Key: TS-1022
>                 URL: https://issues.apache.org/jira/browse/TS-1022
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 3.1.0
>            Reporter: Alan M. Carroll
>            Assignee: Alan M. Carroll
>            Priority: Minor
>             Fix For: 3.1.2
>
>
> LogEntryHeader in proxy/logging/LogBuffer.h uses the type "long" and "unsigned" even though is used directly as serialized data. This means (among other things) that binary logs have different formats depending on whether ATS was built in 32 bit mode or 64 bit mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TS-1022) LogEntryHeader is a serialized structure but uses vague types.

Posted by "Alan M. Carroll (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150054#comment-13150054 ] 

Alan M. Carroll commented on TS-1022:
-------------------------------------

LogBufferHeader in the same file is an even worse example but that's for another bug.
                
> LogEntryHeader is a serialized structure but uses vague types.
> --------------------------------------------------------------
>
>                 Key: TS-1022
>                 URL: https://issues.apache.org/jira/browse/TS-1022
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 3.1.0
>            Reporter: Alan M. Carroll
>            Assignee: Alan M. Carroll
>            Priority: Minor
>             Fix For: 3.1.2
>
>
> LogEntryHeader in proxy/logging/LogBuffer.h uses the type "long" and "unsigned" even though is used directly as serialized data. This means (among other things) that binary logs have different formats depending on whether ATS was built in 32 bit mode or 64 bit mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira