You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/11/01 21:36:46 UTC

Re: Review Request 27138: Manage Ambari and Dashboard should NOT open in named tabs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27138/
-----------------------------------------------------------

(Updated Nov. 1, 2014, 8:36 p.m.)


Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.


Bugs: ambari-7303
    https://issues.apache.org/jira/browse/ambari-7303


Repository: ambari


Description
-------

On deployed cluster login to ambari dashboard.
Go to Admin- Manage Ambari;
New tab is opened with admin view.
In new tab click log out.
Log in again. Dashboard is shown.
Go to Admin- Manage Ambari;
New tab is not opened, but Admin view is shown in current tab, even if first tab was closed.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/views/main.html 3b96b4c 

Diff: https://reviews.apache.org/r/27138/diff/


Testing
-------

Tested manually.


File Attachments (updated)
----------------

AMBARI-7303.patch
  https://reviews.apache.org/media/uploaded/files/2014/11/01/5eff98dc-89a7-4e1f-bd19-67f20a3b58ce__AMBARI-7303.patch


Thanks,

Oleg Nechiporenko


Re: Review Request 27138: Manage Ambari and Dashboard should NOT open in named tabs

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27138/#review59501
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Nov. 1, 2014, 8:36 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27138/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 8:36 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
> 
> 
> Bugs: ambari-7303
>     https://issues.apache.org/jira/browse/ambari-7303
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On deployed cluster login to ambari dashboard.
> Go to Admin- Manage Ambari;
> New tab is opened with admin view.
> In new tab click log out.
> Log in again. Dashboard is shown.
> Go to Admin- Manage Ambari;
> New tab is not opened, but Admin view is shown in current tab, even if first tab was closed.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/main.html 3b96b4c 
> 
> Diff: https://reviews.apache.org/r/27138/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-7303.patch
>   https://reviews.apache.org/media/uploaded/files/2014/11/01/5eff98dc-89a7-4e1f-bd19-67f20a3b58ce__AMBARI-7303.patch
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>


Re: Review Request 27138: Manage Ambari and Dashboard should NOT open in named tabs

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27138/#review59502
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Лис. 1, 2014, 8:36 після полудня, Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27138/
> -----------------------------------------------------------
> 
> (Updated Лис. 1, 2014, 8:36 після полудня)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
> 
> 
> Bugs: ambari-7303
>     https://issues.apache.org/jira/browse/ambari-7303
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On deployed cluster login to ambari dashboard.
> Go to Admin- Manage Ambari;
> New tab is opened with admin view.
> In new tab click log out.
> Log in again. Dashboard is shown.
> Go to Admin- Manage Ambari;
> New tab is not opened, but Admin view is shown in current tab, even if first tab was closed.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/main.html 3b96b4c 
> 
> Diff: https://reviews.apache.org/r/27138/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-7303.patch
>   https://reviews.apache.org/media/uploaded/files/2014/11/01/5eff98dc-89a7-4e1f-bd19-67f20a3b58ce__AMBARI-7303.patch
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>