[GitHub] [tvm] tkonolige commented on a change in pull request #8948: [Hexagon] Sort functions before adding to LLVM codegen

[GitBox <gi...@apache.org>]

tkonolige commented on a change in pull request #8948:
URL: https://github.com/apache/tvm/pull/8948#discussion_r703908741



##########
File path: src/target/llvm/codegen_hexagon.cc
##########
@@ -730,6 +730,12 @@ runtime::Module BuildHexagon(IRModule mod, Target target) {
     funcs.emplace_back(f);
   }
 
+  std::sort(funcs.begin(), funcs.end(), [](PrimFunc func_a, PrimFunc func_b) {

Review comment:
       There are definitely more places in the compiler where the names should be sorted for reproducibility. I had a branch where I tried to make codegen more reproducible, but I can't find it. I remember adding sorts to llvm codegen as well as some places where IRModules were constructed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org