You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Anthony Molinaro (JIRA)" <ji...@apache.org> on 2009/12/12 00:50:18 UTC
[jira] Created: (THRIFT-646) Erlang library is missing install
target
Erlang library is missing install target
----------------------------------------
Key: THRIFT-646
URL: https://issues.apache.org/jira/browse/THRIFT-646
Project: Thrift
Issue Type: Bug
Affects Versions: 0.2
Reporter: Anthony Molinaro
Attachments: erl.patch, Makefile.am
The lib/erl/Makefile current contains
install: all
echo 'No install target, sorry.'
The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899917#action_12899917 ]
David Reiss commented on THRIFT-646:
------------------------------------
Why don't we just make sure that all of our release tarballs are built with autoconf 2.65 or greater?
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (THRIFT-646) Erlang library is missing install
target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Molinaro reopened THRIFT-646:
-------------------------------------
Assignee: David Reiss (was: Anthony Molinaro)
Actually, I just noticed in trying out the 0.4.0 tar which supposedly fixes this that your update to my patch installs the library in the wrong place. Instead of getting the install directory by asking erl where it is in the Makefile.am like
ERL_LIB_ROOT_DIR=$(shell erl -eval 'io:format("~s~n", [code:lib_dir()])' -s init stop -noshell)
you call a macro called AC_ERLANG_SUBST_INSTALL_LIB_DIR which for some reason is based on libdir? There seems to be a macro called AC_ERLANG_SUBST_LIB_DIR which is equivalent to the line above in that it calls code:lib_dir() and uses that
as a substitution value. So maybe change to AC_ERLANG_SUBST_LIB_DIR in configure.ac, and use $(ERLANG_LIB_DIR)/$(AC_PACKAGE_NAME)-$(AC_PACKAGE_VERSION) in place of $(ERLANG_INSTALL_LIB_DIR_thrift) in the lib/erl/Makefile.am?
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-646:
-------------------------------
Attachment: v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-646.
--------------------------------
Fix Version/s: 0.5
(was: 0.4)
Resolution: Fixed
One downside of this is that it doesn't allow the erlang install dir to be overridden on the command line. I think it will be a pretty easy fix if we ever have to do it, though.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.5
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900308#action_12900308 ]
Bryan Duxbury commented on THRIFT-646:
--------------------------------------
My autoconf is indeed 2.65.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899637#action_12899637 ]
David Reiss commented on THRIFT-646:
------------------------------------
I think AC_ERLANG_SUBST_LIB_DIR is meant to find a working version of erlang and AC_ERLANG_SUBST_INSTALL_LIB_DIR is for where to install the packages. Is there a reason you can't set libdir or the environment variable ERLANG_INSTALL_LIBDIR? If so, we could possibly run AC_ERLANG_SUBST_LIB_DIR and seth the ERLANG_INSTALL_LIB_DIR environment variable to the result.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "Eugene Letuchy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875844#action_12875844 ]
Eugene Letuchy commented on THRIFT-646:
---------------------------------------
Go for it. Though
http://lists.gnu.org/archive/html/bug-autoconf/2010-05/msg00003.html is a little
off-putting.
- Eugene
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "Michael Lum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900299#action_12900299 ]
Michael Lum commented on THRIFT-646:
------------------------------------
THRIFT-858 will help ensure autoconf 2.65 or greater is used.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-646:
-------------------------------
Attachment: v1-0001-THRIFT-646.-erlang-Fix-build-on-machines-without-Erl.patch
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.5
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Fix-build-on-machines-without-Erl.patch, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-646) Erlang library is missing install
target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Molinaro updated THRIFT-646:
------------------------------------
Attachment: erlang-install-dir.patch
If Brian is willing to do releases using autoconf 2.65 or greater when he does releases here's a patch for this problem. If not, we'll have to back out to my original solution.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-646) Erlang library is missing install
target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Molinaro updated THRIFT-646:
------------------------------------
Attachment: erl.patch
Makefile.am
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Attachments: erl.patch, Makefile.am
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by Eugene Letuchy <el...@facebook.com>.
Go for it. Though
http://lists.gnu.org/archive/html/bug-autoconf/2010-05/msg00003.html is a little
off-putting.
- Eugene
On 5/11/10 10:02 AM, David Reiss (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866207#action_12866207 ]
>
> David Reiss commented on THRIFT-646:
> ------------------------------------
>
> Anyone care if I commit this follow-up patch?
>
>> Erlang library is missing install target
>> ----------------------------------------
>>
>> Key: THRIFT-646
>> URL: https://issues.apache.org/jira/browse/THRIFT-646
>> Project: Thrift
>> Issue Type: Bug
>> Affects Versions: 0.2
>> Reporter: Anthony Molinaro
>> Assignee: Anthony Molinaro
>> Fix For: 0.4
>>
>> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>>
>>
>> The lib/erl/Makefile current contains
>> install: all
>> echo 'No install target, sorry.'
>> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
>> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
>> The current lib/erl/Makefile should be removed.
>
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866207#action_12866207 ]
David Reiss commented on THRIFT-646:
------------------------------------
Anyone care if I commit this follow-up patch?
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902044#action_12902044 ]
David Reiss commented on THRIFT-646:
------------------------------------
Looks like this broke the build on machines without erlang? Patch attached.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.5
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Fix-build-on-machines-without-Erl.patch, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-646) Erlang library is missing install
target
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-646.
--------------------------------
Assignee: Anthony Molinaro
Fix Version/s: 0.4
Resolution: Fixed
I just committed this.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: Anthony Molinaro
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899957#action_12899957 ]
Anthony Molinaro commented on THRIFT-646:
-----------------------------------------
That works, I just created a small configure.ac with the lines in my last comment, then ran autoconf 2.63 on it, and checked that it failed. Then updated to 2.65 reran autoconf, watched it succeed, then copied the configure script to a box with autoconf 2.59 and also watched it succeed. So as long as we can guarantee the releaser is building with 2.65 or greater, I think we are good with adding
AC_ERLANG_SUBST_LIB_DIR
ERLANG_INSTALL_LIB_DIR=${ERLANG_LIB_DIR}
before the call to
AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902054#action_12902054 ]
Anthony Molinaro commented on THRIFT-646:
-----------------------------------------
Looks good to me.
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.5
>
> Attachments: erl.patch, erlang-install-dir.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Fix-build-on-machines-without-Erl.patch, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-646) Erlang library is missing install
target
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899737#action_12899737 ]
Anthony Molinaro commented on THRIFT-646:
-----------------------------------------
I could set the environment variable, but I sort of feel using erlang should be as easy to use as perl and python (both of which figure out the appropriate place to install on the system and put themselves there, but provide variable to override those choices). I see looking at the m4 again that the AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR does work with the ERLANG_INSTALL_LIB_DIR environment variable. I just tried this
AC_ERLANG_PATH_ERL
AC_ERLANG_PATH_ERLC
AC_ERLANG_SUBST_LIB_DIR
ERLANG_INSTALL_LIB_DIR=${ERLANG_LIB_DIR}
AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
which appears to work, but only with autoconf 2.65, 2.63 did not work. I guess it's some sort of bug with 2.63.
Also for some reason even just doing
ERLANG_INSTALL_LIB_DIR=`$ERL -eval 'io:format("~s~n", @<:@code:lib_dir()@:>@)' -s init stop -noshell`
failed in 2.63 but succeeded in 2.65. Changing $ERL to erl does seem to work with 2.63 for whatever reason.
Seems like this is a somewhat known issue https://support.process-one.net/browse/EXMPP-35?focusedCommentId=41182&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
Anyway, that makes the overriding of the environment variable in configure.ac seem sort of annoying.
What I had before doing this in the Makefile.am worked fine. You could guard a little bit by changing my use of erl with $ERL but that may fail for some odd reason as well.
Hmm, well, I still think it would be best if erlang installed itself in a place it can just run, the Makefile.am way I had originally seems to work regardless of autoconf version, so some variation of it might be best?
> Erlang library is missing install target
> ----------------------------------------
>
> Key: THRIFT-646
> URL: https://issues.apache.org/jira/browse/THRIFT-646
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.2
> Reporter: Anthony Molinaro
> Assignee: David Reiss
> Fix For: 0.4
>
> Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
> echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang. This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.