You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinson Lee <vl...@freedesktop.org> on 2014/01/16 00:08:39 UTC
Review Request 16924: libprocess: Require libc++ only on Mac OS X.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16924/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, Ian Downes, Jie Yu, samya, and Vinod Kone.
Repository: mesos-git
Description
-------
From: Vinson Lee <vl...@twitter.com>
Subject: [PATCH] libprocess: Require libc++ only on Mac OS X.
This patch fixes configure failure on Linux clang builds.
Signed-off-by: Vinson Lee <vl...@twitter.com>
Diffs
-----
3rdparty/libprocess/configure.ac e461590
Diff: https://reviews.apache.org/r/16924/diff/
Testing
-------
See https://reviews.apache.org/r/16909.
Per Vinod Kone's comments in RB 16909, the libprocess configure changes have been split out into this review.
Thanks,
Vinson Lee
Re: Review Request 16924: libprocess: Require libc++ only on Mac OS X.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16924/#review31955
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 15, 2014, 11:08 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16924/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 11:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, Ian Downes, Jie Yu, samya, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> From: Vinson Lee <vl...@twitter.com>
> Subject: [PATCH] libprocess: Require libc++ only on Mac OS X.
>
> This patch fixes configure failure on Linux clang builds.
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e461590
>
> Diff: https://reviews.apache.org/r/16924/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/16909.
>
> Per Vinod Kone's comments in RB 16909, the libprocess configure changes have been split out into this review.
>
>
> Thanks,
>
> Vinson Lee
>
>
Re: Review Request 16924: libprocess: Require libc++ only on Mac OS X.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16924/#review33889
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 15, 2014, 11:08 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16924/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 11:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, Ian Downes, Jie Yu, samya, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> From: Vinson Lee <vl...@twitter.com>
> Subject: [PATCH] libprocess: Require libc++ only on Mac OS X.
>
> This patch fixes configure failure on Linux clang builds.
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e461590
>
> Diff: https://reviews.apache.org/r/16924/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/16909.
>
> Per Vinod Kone's comments in RB 16909, the libprocess configure changes have been split out into this review.
>
>
> Thanks,
>
> Vinson Lee
>
>