You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/20 09:27:05 UTC
[GitHub] [incubator-druid] kamaci commented on a change in pull request
#6943: InterruptedExceptions should never be ignored in the code.
kamaci commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code.
URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r315592127
##########
File path: core/src/main/java/org/apache/druid/collections/DefaultBlockingPool.java
##########
@@ -86,6 +86,7 @@ public int getPoolSize()
return wrapObject(timeoutMs > 0 ? pollObject(timeoutMs) : pollObject());
}
catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
Review comment:
> BTW, I'm fine by making another PR for this change. This PR is still worth without it.
@leventov this PR is closed due to inactivity. However, it can be merged since https://github.com/apache/incubator-druid/pull/7121 has merged too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org