You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/10/08 18:10:50 UTC

[GitHub] [parquet-mr] belugabehr commented on a change in pull request #825: PARQUET-1922: Deprecate IOExceptionUtils

belugabehr commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r501917260



##########
File path: parquet-common/src/main/java/org/apache/parquet/bytes/LittleEndianDataOutputStream.java
##########
@@ -210,8 +207,8 @@ public final void writeDouble(double v) throws IOException {
     writeLong(Double.doubleToLongBits(v));
   }
 
-  public void close() {
-    IOExceptionUtils.closeQuietly(out);
+  public void close() throws IOException {

Review comment:
       The inherited `close()` method throws IOException so this is fine to do




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org