You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/02/09 04:32:26 UTC

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21020


Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................

IMPALA-12801: Increase query_log_size from 100 to 200.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' as an additional safeguard
to evict entry from query_log_ when this limit exceeded, preventing
query_log_ total memory to grow prohibitively large.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M tests/custom_cluster/test_web_pages.py
3 files changed, 64 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

LGTM!

http://gerrit.cloudera.org:8080/#/c/21020/6/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/6/be/src/service/impala-server.cc@1185
PS6, Line 1185: r::EstimateS
> I initially hesitant to count for thrift members since they might be nested
Thank you for these changes. It's indeed tricky to accurately calculate the memory consumption of these. I think this rough estimate is sufficient for this scenario, and a more precise calculation might not be worth it.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 06:50:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10282/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 18:17:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21020/7/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/7/be/src/service/impala-server.cc@1219
PS7, Line 1219: ;
nit: remove the extra semi-colon.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 12:11:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl@30
PS5, Line 30: si
> Rephrased this line. Move it out of lead line.
I think "is" is correct in the rephrased sentence.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 07:21:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 10: Code-Review+2

Carry +2


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 23:53:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has removed a vote on this change.

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Removed Code-Review+2 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10297/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 16:19:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/15214/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2024 04:53:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................

IMPALA-12801: Increase query_log_ default size and bound its memory.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Reviewed-on: http://gerrit.cloudera.org:8080/21020
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M docs/topics/impala_webui.xml
M tests/custom_cluster/test_web_pages.py
M www/queries.tmpl
5 files changed, 110 insertions(+), 14 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 13
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21020/5/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:

http://gerrit.cloudera.org:8080/#/c/21020/5/docs/topics/impala_webui.xml@582
PS5, Line 582: option
> nit: options
Done


http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl@30
PS5, Line 30: si
> nit: are
Rephrased this line. Move it out of lead line.


http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl@31
PS5, Line 31: 
> nit: parameters
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 07:12:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1198
PS9, Line 1198: that
nit: "than"


http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1208
PS9, Line 1208: auto
nit: use "const auto&". I think that's why the clang-tidy job failed.


http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1217
PS9, Line 1217: auto
nit: const auto&


http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1225
PS9, Line 1225: auto
nit: const auto&



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 08:54:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 00:41:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 03:09:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10286/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 03:57:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Yifan Zhang, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#6).

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................

IMPALA-12801: Increase query_log_size from 100 to 200.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M docs/topics/impala_webui.xml
M tests/custom_cluster/test_web_pages.py
M www/queries.tmpl
5 files changed, 73 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/6
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Yifan Zhang, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#7).

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................

IMPALA-12801: Increase query_log_ default size and bound its memory.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M docs/topics/impala_webui.xml
M tests/custom_cluster/test_web_pages.py
M www/queries.tmpl
5 files changed, 110 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/7
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15231/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 17:15:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Yifan Zhang, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#10).

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................

IMPALA-12801: Increase query_log_ default size and bound its memory.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M docs/topics/impala_webui.xml
M tests/custom_cluster/test_web_pages.py
M www/queries.tmpl
5 files changed, 110 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/10
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 11: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10289/


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 04:26:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 03:50:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 12: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 21:01:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10282/


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 22:56:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21020/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21020/1//COMMIT_MSG@16
PS1, Line 16: query_log_size_in_bytes
Could you mention the default value of this flag variable, and behavior when both flags are set with positive value, e.g. whichever is less ?


http://gerrit.cloudera.org:8080/#/c/21020/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/1/be/src/service/impala-server.cc@1185
PS1, Line 1185: size()
should call capacity() here and below for allocated buffer size.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 08:34:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21020/4/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/21020/4/www/queries.tmpl@30
PS4, Line 30: The size of that archive is controlled with the
            : <samp>--query_log_size</samp> and <samp>--query_log_size_
> nit: This should be updated.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 04:19:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 10:13:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21020/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21020/6//COMMIT_MSG@7
PS6, Line 7: Increase query_log_size from 100 to 200.
nit: This doesn't seem to be the main content of this patch. Perhaps we should focus on the newly added flag query_log_size_in_bytes?


http://gerrit.cloudera.org:8080/#/c/21020/6/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/6/be/src/service/impala-server.cc@1185
PS6, Line 1185: EstimateSize
There are some other member variables that also hold dynamic memory. Shouldn't we also account for them? Namely exec_summary, query_status, event_sequence, and fragments.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 02:52:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#4).

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................

IMPALA-12801: Increase query_log_size from 100 to 200.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M tests/custom_cluster/test_web_pages.py
3 files changed, 66 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/4
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Yifan Zhang, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#5).

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................

IMPALA-12801: Increase query_log_size from 100 to 200.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M docs/topics/impala_webui.xml
M tests/custom_cluster/test_web_pages.py
M www/queries.tmpl
5 files changed, 69 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/5
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10289/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 23:53:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Yifan Zhang, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#8).

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................

IMPALA-12801: Increase query_log_ default size and bound its memory.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M docs/topics/impala_webui.xml
M tests/custom_cluster/test_web_pages.py
M www/queries.tmpl
5 files changed, 110 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/8
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 03:57:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 11:

> Patch Set 11: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10289/

Hit a known flaky test_reuse_partitions_transactional.
I'll try rerun GVO while investigating the flakiness in test_reuse_partitions_transactional.


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 16:18:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21020/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21020/6//COMMIT_MSG@7
PS6, Line 7: Increase query_log_ default size and bou
> nit: This doesn't seem to be the main content of this patch. Perhaps we sho
Rephrased the commit title.


http://gerrit.cloudera.org:8080/#/c/21020/6/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/6/be/src/service/impala-server.cc@1185
PS6, Line 1185: r::EstimateS
> There are some other member variables that also hold dynamic memory. Should
I initially hesitant to count for thrift members since they might be nested.
I added crude estimate in ps7 and disclaimer in method's comment that the returned value does not meant to be precise.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 04:45:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 23:53:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 10:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1198
PS9, Line 1198: than
> nit: "than"
Done


http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1208
PS9, Line 1208: cons
> nit: use "const auto&". I think that's why the clang-tidy job failed.
Done


http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1217
PS9, Line 1217: cons
> nit: const auto&
Done


http://gerrit.cloudera.org:8080/#/c/21020/9/be/src/service/impala-server.cc@1225
PS9, Line 1225: cons
> nit: const auto&
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 16:17:58 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Zihao Ye, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21020

to look at the new patch set (#2).

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................

IMPALA-12801: Increase query_log_size from 100 to 200.

Coordinator's /queries page is useful to show information about recently
run and completed queries. Having more entries will be helpful to
inspect queries that completed further back. The maximum entry of this
table is controlled by 'query_log_size' flag. Higher value means more
queries to keep, but it also cost more memory overhead in coordinator.

This patch increase 'query_log_size' default value from 100 to 200. This
patch also add flag 'query_log_size_in_bytes' (default to 2GB) as an
additional safeguard to evict entry from query_log_ when this limit
exceeded, preventing query_log_ total memory to grow prohibitively
large. 'query_log_size_in_bytes' is used in combination with
'query_log_size' to limit the number of QueryStateRecord to retain in
query_log_, whichever is less.

Testing:
- Pass exhaustive tests.

Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M tests/custom_cluster/test_web_pages.py
3 files changed, 64 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/21020/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21020/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21020/1//COMMIT_MSG@16
PS1, Line 16: query_log_size_in_bytes
> Could you mention the default value of this flag variable, and behavior whe
Done


http://gerrit.cloudera.org:8080/#/c/21020/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/1/be/src/service/impala-server.cc@1185
PS1, Line 1185: capaci
> should call capacity() here and below for allocated buffer size.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 16:50:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21020/5/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:

http://gerrit.cloudera.org:8080/#/c/21020/5/docs/topics/impala_webui.xml@582
PS5, Line 582: option
nit: options


http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl@30
PS5, Line 30: is
nit: are


http://gerrit.cloudera.org:8080/#/c/21020/5/www/queries.tmpl@31
PS5, Line 31: parameter
nit: parameters



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 06:39:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 4:

ps4 fix bug in the loop.


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 00:25:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21020/7/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/21020/7/be/src/service/impala-server.cc@1219
PS7, Line 1219: 
> nit: remove the extra semi-colon.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Feb 2024 17:56:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 00:42:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15249/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sat, 17 Feb 2024 00:49:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 01:37:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21020/4/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/21020/4/www/queries.tmpl@30
PS4, Line 30: The size of that archive is controlled with the
            : <samp>--query_log_size</samp> command line parameter.</p>
nit: This should be updated.



-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 04:01:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10286/


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 08:33:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Sun, 18 Feb 2024 13:48:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log default size and bound its memory.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_ default size and bound its memory.
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 16:19:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12801: Increase query log size from 100 to 200.

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21020 )

Change subject: IMPALA-12801: Increase query_log_size from 100 to 200.
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I107e2c2c7f2b239557be37360e8eecf5479e8602
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 14 Feb 2024 00:47:36 +0000
Gerrit-HasComments: No