You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 13:16:06 UTC
[GitHub] [flink] XComp commented on a change in pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build
XComp commented on a change in pull request #13779:
URL: https://github.com/apache/flink/pull/13779#discussion_r511949631
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -19,6 +19,8 @@
source "$(dirname "$0")"/common_kubernetes.sh
+IMAGE_BUILD_RETRIES=3
Review comment:
What's the reason to use a separate variable that is only used in one place? Might it be better to just move the 3 into the `retry_items` call? ...since we do it for the backoff parameter like that as well. 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org