You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "otrebor (via GitHub)" <gi...@apache.org> on 2024/11/27 13:51:04 UTC
[I] Improve documentation for TALISMAN configuration [superset]
otrebor opened a new issue, #31180:
URL: https://github.com/apache/superset/issues/31180
### Bug description
I struggled on understanding that the variable TALISMAN_CONFIG is not used when superset is run in DEBUG mode.
I suggest to mention it in the documentation and just mention the name of the variable TALISMAN_DEV_CONFIG.
https://github.com/apache/superset/edit/master/docs/docs/configuration/networking-settings.mdx
### Screenshots/recordings
_No response_
### Superset version
master / latest-dev
### Python version
Not applicable
### Node version
Not applicable
### Browser
Not applicable
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Improve documentation for TALISMAN configuration [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #31180:
URL: https://github.com/apache/superset/issues/31180#issuecomment-2842908395
This has been silent for quite a while. I'm not sure people would find the docs if they don't see it right there in the config file. I'll close this as not-planned/inactive, but we're VERY open to a docs PR if anyone is interested in opening one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Improve documentation for TALISMAN configuration [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #31180: Improve documentation for TALISMAN configuration
URL: https://github.com/apache/superset/issues/31180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Improve documentation for TALISMAN configuration [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #31180:
URL: https://github.com/apache/superset/issues/31180#issuecomment-2529116742
Do you have suggestions of how to write this up or where? We're certainly open to a PR to the docs if you feel up to it. Meanwhile, in the `config.py` file, I thought it was pretty clear that the `TALISMAN_DEV_CONFIG` is right below `TALISMAN_CONFIG`... would a comment in that file pointing this out help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Improve documentation for TALISMAN configuration [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #31180:
URL: https://github.com/apache/superset/issues/31180#issuecomment-2560224998
Maybe we could document the full extent of what happens when `DEBUG` mode is used? I have not used that mode so am not sure what exists already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org