You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/01 12:31:20 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #3931: [ZEPPELIN-5079] commons-io update zeppelin-markdown

Reamer opened a new pull request #3931:
URL: https://github.com/apache/zeppelin/pull/3931


   ### What is this PR for?
   Includes:
    - Update commons-io to parent pom
    - some small style changes
    - create MarkdownUtils to remove duplicate code
   
   ### What type of PR is it?
    - Improvement
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5079
   
   ### How should this be tested?
   * Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/731917537
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3931: [ZEPPELIN-5079] commons-io update zeppelin-markdown

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3931:
URL: https://github.com/apache/zeppelin/pull/3931#issuecomment-704189749


   After some manual tests I found out that the communication with websequencediagrams.com was broken. I think because of 'https'. Therefore I decide to use `org.apache.httpcomponents:httpclient` for a clean API communication.
   Now it's working
   ![Zeppelin_markdown](https://user-images.githubusercontent.com/454320/95192714-e3b8d580-07d2-11eb-969a-8c7ebb57867c.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3931: [ZEPPELIN-5079] commons-io update zeppelin-markdown

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3931:
URL: https://github.com/apache/zeppelin/pull/3931#issuecomment-704190435


   If there are no further comments, I will merge this PR into Master and Branch-0.9 on Thursday (08.10.2020)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3931: [ZEPPELIN-5079] Rewrite communication with websequencediagrams in zeppelin-markdown

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3931:
URL: https://github.com/apache/zeppelin/pull/3931


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3931: [ZEPPELIN-5079] Rewrite communication with websequencediagrams in zeppelin-markdown

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3931:
URL: https://github.com/apache/zeppelin/pull/3931


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3931: [ZEPPELIN-5079] commons-io update zeppelin-markdown

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3931:
URL: https://github.com/apache/zeppelin/pull/3931#issuecomment-702723016


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org