You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/12/15 14:45:05 UTC

(commons-dbcp) 01/05: Add TestInstanceKeyDataSource.testValidationQueryTimeoutDuration()

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit db5e0764283f9244489de9ea8ab1375498c85a5d
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Sun Dec 15 08:24:50 2024 -0500

    Add TestInstanceKeyDataSource.testValidationQueryTimeoutDuration()
---
 .../commons/dbcp2/datasources/TestInstanceKeyDataSource.java      | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java b/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java
index 75010e39..b26902a8 100644
--- a/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java
+++ b/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java
@@ -28,6 +28,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 import java.io.PrintWriter;
 import java.sql.Connection;
 import java.sql.SQLException;
+import java.time.Duration;
 import java.util.Properties;
 
 import org.apache.commons.dbcp2.cpdsadapter.DriverAdapterCPDS;
@@ -313,6 +314,13 @@ public class TestInstanceKeyDataSource {
         assertEquals(10, spds.getValidationQueryTimeout());
     }
 
+    @Test
+    public void testValidationQueryTimeoutDuration() {
+        assertEquals(Duration.ofSeconds(-1), spds.getValidationQueryTimeoutDuration());
+        spds.setValidationQueryTimeout(Duration.ofSeconds(10));
+        assertEquals(Duration.ofSeconds(10), spds.getValidationQueryTimeoutDuration());
+    }
+
     @Test
     public void testValidationQueryWithConnectionCalled() throws SQLException {
         try (Connection connection = spds.getConnection()) {