You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by al...@apache.org on 2007/11/05 00:15:44 UTC
svn commit: r591861 -
/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java
Author: almaw
Date: Sun Nov 4 15:15:43 2007
New Revision: 591861
URL: http://svn.apache.org/viewvc?rev=591861&view=rev
Log:
Comment on previous commit.
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java
Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java?rev=591861&r1=591860&r2=591861&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java Sun Nov 4 15:15:43 2007
@@ -259,6 +259,9 @@
*/
public final void setCurrentPage(int page)
{
+ // If page == 0, short-circuit the range check. This saves a call to
+ // getPageCount(), but more importantly avoids it being called until
+ // your AbstractPageableView is actually rendered.
if (page != 0 && (page < 0 || (page >= getPageCount() && getPageCount() > 0)))
{
throw new IndexOutOfBoundsException("argument [page]=" + page + ", must be 0<=page<" +