Slack digest for #dev - 2020-05-23

[Apache Pulsar Slack <ap...@gmail.com>]

2020-05-22 09:48:39 UTC - Vladimir Shchur: @Matteo Merli can you please comment on that? I see it was your comment in the code
----
2020-05-22 09:52:29 UTC - Vladimir Shchur: @Penghui Li would you mind giving your thoughts on that?
----
2020-05-22 10:10:40 UTC - Penghui Li: Ok, looks the broker set a wrong value
----
2020-05-22 10:16:45 UTC - Penghui Li: I think the broker response 0 to the client is ok
```// Add check `sequenceId >= highestSequenceId` for backward compatibility.
if (sequenceId >= highestSequenceId || highestSequenceId == op.highestSequenceId) {
                    // Message was persisted correctly
                    if (log.isDebugEnabled()) {
                        log.debug("[{}] [{}] Received ack for msg {} ", topic, producerName, sequenceId);
                    }
                    pendingMessages.remove();
                    releaseSemaphoreForSendOp(op);
                    callback = true;
                    pendingCallbacks.add(op);
                }```
----
2020-05-22 10:56:30 UTC - Vladimir Shchur: Right, both are ok when converted to long.
----
2020-05-22 22:27:53 UTC - Jarrod Johnson: @Jarrod Johnson has joined the channel
----
2020-05-22 22:29:07 UTC - Jarrod Johnson: Hello all! Probably a rookie mistake here but I'm trying to just follow the tutorial on creating a function and I keep getting the following error: "Was passed main parameter 'sanitizer-logs' but no main parameter was defined". The command I am running is: `docker run apachepulsar/pulsar bin/pulsar-admin functions localrun --py clean-string.py --classname sanitizer --tenant public --namespace default --name sanitizer-function --inputs dirty-strings-in --output --log-topic sanitizer-logs`
----
2020-05-22 22:29:23 UTC - Jarrod Johnson: If anyone could point me in the right direction it would be much appreciated! Thanks!
----
2020-05-22 22:30:10 UTC - Jarrod Johnson: I've also tried running the command inside the docker container but same result
----
2020-05-23 03:59:25 UTC - Sijie Guo: You need a parameter for `--output`
----
2020-05-23 03:59:48 UTC - Sijie Guo: So that command should be `--output <output-topic> --log-topic <log-topic>`
----