You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/09 11:27:26 UTC
[GitHub] [ozone-go] adoroszlai opened a new pull request #2: HDDS-5081. Fix key put implementation
adoroszlai opened a new pull request #2:
URL: https://github.com/apache/ozone-go/pull/2
## What changes were proposed in this pull request?
Replace hard-coded `/tmp/asd` local file with command-line argument for `key put` operation.
https://issues.apache.org/jira/browse/HDDS-5081
## How was this patch tested?
```
./ozone-go --om localhost key put vol1/bucket1/passwd /etc/passwd
```
NOTE: this PR is intentionally created with a compile error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-go] cxorm commented on a change in pull request #2: HDDS-5081. Fix key put implementation
Posted by GitBox <gi...@apache.org>.
cxorm commented on a change in pull request #2:
URL: https://github.com/apache/ozone-go/pull/2#discussion_r611181919
##########
File path: cli/main.go
##########
@@ -197,7 +197,7 @@ func main() {
Action: func(c *cli.Context) error {
ozoneClient := api.CreateOzoneClient(c.GlobalString("om"))
address := OzoneObjectAddressFromString(c.Args().Get(0))
- f, err := os.Open("/tmp/asd")
+ f, err := os.Open(c.Args().Get(1)
Review comment:
This change improves flexibility IMHO.
Thanks @adoroszlai for the contribution,
+1 (Let's merge it after importing POC code.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-go] adoroszlai closed pull request #2: HDDS-5081. Fix key put implementation
Posted by GitBox <gi...@apache.org>.
adoroszlai closed pull request #2:
URL: https://github.com/apache/ozone-go/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-go] cxorm commented on a change in pull request #2: HDDS-5081. Fix key put implementation
Posted by GitBox <gi...@apache.org>.
cxorm commented on a change in pull request #2:
URL: https://github.com/apache/ozone-go/pull/2#discussion_r611181919
##########
File path: cli/main.go
##########
@@ -197,7 +197,7 @@ func main() {
Action: func(c *cli.Context) error {
ozoneClient := api.CreateOzoneClient(c.GlobalString("om"))
address := OzoneObjectAddressFromString(c.Args().Get(0))
- f, err := os.Open("/tmp/asd")
+ f, err := os.Open(c.Args().Get(1)
Review comment:
This change improves flexible IMHO.
Thanks @adoroszlai for the contribution,
+1 (Let's merge it after importing POC code.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone-go] adoroszlai commented on pull request #2: HDDS-5081. Fix key put implementation
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2:
URL: https://github.com/apache/ozone-go/pull/2#issuecomment-816831068
Will recreate once code import is sorted out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org