[GitHub] john-bodley commented on a change in pull request #4704: allow customizable caching permissions

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #4704: allow customizable caching permissions
URL: https://github.com/apache/incubator-superset/pull/4704#discussion_r178210259
 
 

 ##########
 File path: superset/security.py
 ##########
 @@ -110,6 +110,10 @@ def schema_access(self, datasource, user=None):
             self.can_access('schema_access', datasource.schema_perm, user=user)
         )
 
+    def has_cache_access(self, datasource):
+        # By default datasource access implies cache access.
+        return self.datasource_access(datasource)
 
 Review comment:
   Could we make this return `True` by default. That's a no-op and the custom security manager could override this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services