You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <br...@vmware.com> on 2020/09/01 14:37:38 UTC
[PROPOSAL] port GEODE-8467 to support/1.13
I’d like to cherry-pick this change into support/1.13:
There is a flaw in the code that handles a server being forced out of the cluster. The flaw keeps the server from shutting down and leaves the server in a hung state. The PR adds error handling to two methods, one in the Cache’s XML-generation method and the other in a Membership class to ensure that tear-down of the cache is performed.
https://github.com/apache/geode/pull/5490
Re: [PROPOSAL] port GEODE-8467 to support/1.13
Posted by Dave Barnes <db...@apache.org>.
OK Bruce, go for it.
Thanks for the fix.
Dave
On Tue, Sep 1, 2020 at 10:43 AM Sarah Abbey <sa...@vmware.com> wrote:
> +1
> ________________________________
> From: Donal Evans <do...@vmware.com>
> Sent: Tuesday, September 1, 2020 1:38 PM
> To: dev@geode.apache.org <de...@geode.apache.org>
> Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13
>
> +1
> ________________________________
> From: Dave Barnes <db...@apache.org>
> Sent: Tuesday, September 1, 2020 10:25 AM
> To: dev@geode.apache.org <de...@geode.apache.org>
> Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13
>
> > Assuming that it's passed applicable testing AND GETS AT LEAST 3 VOTES,
> let's do it.
>
> On Tue, Sep 1, 2020 at 10:24 AM Dave Barnes <db...@apache.org> wrote:
>
> > +1
> > GEODE-8467 addresses one of the few remaining 1.13 release blockers.
> > I see it's been approved and merged into the develop branch. Assuming
> that
> > it's passed applicable testing, let's do it.
> >
> > On Tue, Sep 1, 2020 at 7:37 AM Bruce Schuchardt <br...@vmware.com>
> wrote:
> >
> >> I’d like to cherry-pick this change into support/1.13:
> >>
> >> There is a flaw in the code that handles a server being forced out of
> the
> >> cluster. The flaw keeps the server from shutting down and leaves the
> >> server in a hung state. The PR adds error handling to two methods, one
> in
> >> the Cache’s XML-generation method and the other in a Membership class to
> >> ensure that tear-down of the cache is performed.
> >>
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5490&data=02%7C01%7Csabbey%40vmware.com%7Cbe14c93b2d4d43e31f7708d84e9dd689%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637345787113051903&sdata=TsXIb6rNEAChlQPdDoGztVBayA70xlhGldyktCJwKW4%3D&reserved=0
> >>
> >>
>
Re: [PROPOSAL] port GEODE-8467 to support/1.13
Posted by Sarah Abbey <sa...@vmware.com>.
+1
________________________________
From: Donal Evans <do...@vmware.com>
Sent: Tuesday, September 1, 2020 1:38 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13
+1
________________________________
From: Dave Barnes <db...@apache.org>
Sent: Tuesday, September 1, 2020 10:25 AM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13
> Assuming that it's passed applicable testing AND GETS AT LEAST 3 VOTES,
let's do it.
On Tue, Sep 1, 2020 at 10:24 AM Dave Barnes <db...@apache.org> wrote:
> +1
> GEODE-8467 addresses one of the few remaining 1.13 release blockers.
> I see it's been approved and merged into the develop branch. Assuming that
> it's passed applicable testing, let's do it.
>
> On Tue, Sep 1, 2020 at 7:37 AM Bruce Schuchardt <br...@vmware.com> wrote:
>
>> I’d like to cherry-pick this change into support/1.13:
>>
>> There is a flaw in the code that handles a server being forced out of the
>> cluster. The flaw keeps the server from shutting down and leaves the
>> server in a hung state. The PR adds error handling to two methods, one in
>> the Cache’s XML-generation method and the other in a Membership class to
>> ensure that tear-down of the cache is performed.
>>
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5490&data=02%7C01%7Csabbey%40vmware.com%7Cbe14c93b2d4d43e31f7708d84e9dd689%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637345787113051903&sdata=TsXIb6rNEAChlQPdDoGztVBayA70xlhGldyktCJwKW4%3D&reserved=0
>>
>>
Re: [PROPOSAL] port GEODE-8467 to support/1.13
Posted by Donal Evans <do...@vmware.com>.
+1
________________________________
From: Dave Barnes <db...@apache.org>
Sent: Tuesday, September 1, 2020 10:25 AM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: [PROPOSAL] port GEODE-8467 to support/1.13
> Assuming that it's passed applicable testing AND GETS AT LEAST 3 VOTES,
let's do it.
On Tue, Sep 1, 2020 at 10:24 AM Dave Barnes <db...@apache.org> wrote:
> +1
> GEODE-8467 addresses one of the few remaining 1.13 release blockers.
> I see it's been approved and merged into the develop branch. Assuming that
> it's passed applicable testing, let's do it.
>
> On Tue, Sep 1, 2020 at 7:37 AM Bruce Schuchardt <br...@vmware.com> wrote:
>
>> I’d like to cherry-pick this change into support/1.13:
>>
>> There is a flaw in the code that handles a server being forced out of the
>> cluster. The flaw keeps the server from shutting down and leaves the
>> server in a hung state. The PR adds error handling to two methods, one in
>> the Cache’s XML-generation method and the other in a Membership class to
>> ensure that tear-down of the cache is performed.
>>
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5490&data=02%7C01%7Cdoevans%40vmware.com%7Ca03fd376ab304881170c08d84e9c0cda%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637345779446436246&sdata=XorixZ6YCvZbEk8hV%2Bm2g6Db6jKyZPlFlRTg91PREvU%3D&reserved=0
>>
>>
Re: [PROPOSAL] port GEODE-8467 to support/1.13
Posted by Dave Barnes <db...@apache.org>.
> Assuming that it's passed applicable testing AND GETS AT LEAST 3 VOTES,
let's do it.
On Tue, Sep 1, 2020 at 10:24 AM Dave Barnes <db...@apache.org> wrote:
> +1
> GEODE-8467 addresses one of the few remaining 1.13 release blockers.
> I see it's been approved and merged into the develop branch. Assuming that
> it's passed applicable testing, let's do it.
>
> On Tue, Sep 1, 2020 at 7:37 AM Bruce Schuchardt <br...@vmware.com> wrote:
>
>> I’d like to cherry-pick this change into support/1.13:
>>
>> There is a flaw in the code that handles a server being forced out of the
>> cluster. The flaw keeps the server from shutting down and leaves the
>> server in a hung state. The PR adds error handling to two methods, one in
>> the Cache’s XML-generation method and the other in a Membership class to
>> ensure that tear-down of the cache is performed.
>>
>> https://github.com/apache/geode/pull/5490
>>
>>
Re: [PROPOSAL] port GEODE-8467 to support/1.13
Posted by Dave Barnes <db...@apache.org>.
+1
GEODE-8467 addresses one of the few remaining 1.13 release blockers.
I see it's been approved and merged into the develop branch. Assuming that
it's passed applicable testing, let's do it.
On Tue, Sep 1, 2020 at 7:37 AM Bruce Schuchardt <br...@vmware.com> wrote:
> I’d like to cherry-pick this change into support/1.13:
>
> There is a flaw in the code that handles a server being forced out of the
> cluster. The flaw keeps the server from shutting down and leaves the
> server in a hung state. The PR adds error handling to two methods, one in
> the Cache’s XML-generation method and the other in a Membership class to
> ensure that tear-down of the cache is performed.
>
> https://github.com/apache/geode/pull/5490
>
>