You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 17:26:01 UTC

[GitHub] [beam] kennknowles opened a new issue, #18350: Extract common class for WithTimestamps.AddTimestampsDoFn and Create.TimestampedValues.ConvertTimestamps

kennknowles opened a new issue, #18350:
URL: https://github.com/apache/beam/issues/18350

   It seems like these APIs are predominantly duplicative of each other and, that it's hard to find one of them if you knew about the other.
   
   https://github.com/apache/beam/blob/348d335883b14a9b143b65e4b3c62dc79f62d77e/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/WithTimestamps.java#L134
   
   https://github.com/apache/beam/blob/348d335883b14a9b143b65e4b3c62dc79f62d77e/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Create.java#L560
   
   What would make the most sense to me is if TimestampedValues were implemented in terms of both Values and WithTimestamps.  I'm still learning about Beam though \-- would this approach cause some kind of performance problem?
   
   Imported from Jira [BEAM-1811](https://issues.apache.org/jira/browse/BEAM-1811). Original Jira may contain additional context.
   Reported by: wtanaka.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org