You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/10/18 01:40:13 UTC

[GitHub] [drill] cgivre commented on pull request #2092: DRILL-7763: Add Limit Pushdown to File Based Storage Plugins

cgivre commented on pull request #2092:
URL: https://github.com/apache/drill/pull/2092#issuecomment-711104163


   @vvysotskyi I don't know if you're still looking at this or not, but I refactored the code and it's now ready for review.  I removed the `applyLimit()` function from the `EasyGroupScan` and made some minor modifications to the [`AbstractGroupScanWithMetadata.applyLimit()`](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScanWithMetadata.java#L453) method so that it simply passes down the limit.  
   
   At this point it is up to each format plugin to actually do something with it.  This should not affect the pruning at all. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org