You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/25 12:24:39 UTC

[GitHub] [arrow] dragosmg commented on a change in pull request #12208: ARROW-14419 [R] Add filter + join test

dragosmg commented on a change in pull request #12208:
URL: https://github.com/apache/arrow/pull/12208#discussion_r791659038



##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -173,3 +173,31 @@ test_that("mutate then join", {
     )
   )
 })
+
+test_that("filter then join", {

Review comment:
       I was mostly keeping in style with the [test ](https://github.com/apache/arrow/blob/231d0a6b30e7017f0e07162b6716f3da49a674d0/r/tests/testthat/test-dplyr-join.R#L197)it was meant to complement (which has a brief description also ; `"mutate and join"`). I'm not convinced the [original ticket](https://issues.apache.org/jira/browse/ARROW-14417) is descriptive enough either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org