[GitHub] dhlaluku opened a new pull request #2752: Fix failing test cases and proper resource cleanup

[GitBox <gi...@apache.org>]

dhlaluku opened a new pull request #2752: Fix failing test cases and proper resource cleanup
URL: https://github.com/apache/cloudstack/pull/2752
 
 
   ## Description
   <!--- Describe your changes in detail -->
   This PR fixes the Marvin test failures seen in master for KVM hosts. I found the issue to be caused by the resetVirtualMachinePassword API call in the setUpClass class method, the VM has to be stopped prior to executing this API call.
   API Doc: http://cloudstack.apache.org/api/apidocs-4.11/apis/resetPasswordForVirtualMachine.html
   
   I have added the Stop command before resetting the password and restart the VM afterward. I have found that resources were not being cleaned up after test execution and I have fixed that as well.
   
   I also made some minor changes to make the file Pep 8 compliant.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   
   <!-- Fixes: # -->
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   Start the management server in my local development environment with KVM host and run the associated marvin test:
   
   test/integration/smoke/test_deploy_virtio_scsi_vm.py
   
   Dev environment components:
   - Platform: ACS-4.12
   - Management OS: Ubuntu 18.04 LTS
   - Hypervisor: 1 Host running KVM with CentOS 7
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [x] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services