[GitHub] [druid] jimjoamz commented on a diff in pull request #12791: Fix and document skipIgnorableShards

[GitBox <gi...@apache.org>]

jimjoamz commented on code in PR #12791:
URL: https://github.com/apache/druid/pull/12791#discussion_r922304427


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2328,7 +2328,7 @@ private boolean updatePartitionDataFromStream()
     Set<PartitionIdType> partitionIdsFromSupplier;
     recordSupplierLock.lock();
     try {
-      partitionIdsFromSupplier = recordSupplier.getPartitionIds(ioConfig.getStream());
+      partitionIdsFromSupplier = new TreeSet<>(recordSupplier.getPartitionIds(ioConfig.getStream()));

Review Comment:
   A test case for this feature in general seems warranted to me too.  This bug is trivially reproducible in the version of Druid the feature first shipped in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org