You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/07 10:41:19 UTC

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #7337: [Fix](lateral view)(subquery) Fix the problem that the projection col…

EmmyMiao87 opened a new pull request #7337:
URL: https://github.com/apache/incubator-doris/pull/7337


   …umn is empty
   
   The phenomenon of the problem is that when the results of a inline view are subjected to a lateral view,
   and the outer query performs aggregation or sorting operations on non-table-function columns.
   The output slot id of the table function node is empty or has fewer columns.
   For example, the "aggColumnInOuterQueryWithCorrectProject" query in the single test.
   
   The essential reason is that when the inner layer contains an inline view,
   the outer expression needs to be mapped to the correct tuple through the substitute method
   according to the smap instead of the virtual tuple.
   But the substitute method of slot ref cannot recurse to its own source exprs.
   This pr adds a recursive call to the source exprs of slotref.
   
   E.g
   SlotRef: c2 <source expr min(c1)>
   smap: <c1, c3>
   before: c2 <source expr min(c1)>
   after: c2 <source expr min(c3)>
   
   **WARNING The change of this PR is a common part, which may affect normal queries**
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   - [ ] Optimization. Including functional usability improvements and performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #7337: [Fix](lateral view)(subquery) Forbidden directly AGG/SORT on lateral view

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7337:
URL: https://github.com/apache/incubator-doris/pull/7337


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7337: [Fix](lateral view)(subquery) Forbidden directly AGG/SORT on lateral view

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7337:
URL: https://github.com/apache/incubator-doris/pull/7337#issuecomment-995507425






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org