You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/18 11:36:28 UTC
[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #53: Remove "module" for core components?
mikemccand opened a new issue, #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53
### Description
I noticed we have components like `component:module/core/hnsw`.
Could we remove the `module/` prefix for `core`? It would make the core component strings shorter, which is meaningful/helpful since they are so frequently used?
The other real modules (e.g. `component:module/facet`) I think should keep their `module/` prefix?
Also, I like the issue template testing here!
### Version and Environments
_No response_
### Lucene Component
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1192109634
Yes, I think so. I'm closing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187165708
Also, could we maybe use `fix-version` and `affects-version` instead of `fixVersion` and `affectsVersion`? I think it is more readable on quick glance with a `-`?
I noticed there is also a `type:new_feature` -- maybe we can make that `type:new-feature` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187483046
> Also, could we maybe use `fix-version` and `affects-version` instead of `fixVersion` and `affectsVersion`? I think it is more readable on quick glance with a `-`?
>
> I noticed there is also a `type:new_feature` -- maybe we can make that `type:new-feature` for consistency?
Sure, I have no opinion about the label format and named them without much consideration. I will update these lines.
https://github.com/apache/lucene-jira-archive/blob/e3ec8c748bc6e2887190f4b7c93288da0d31b0af/migration/src/jira2github_import.py#L158-L168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1192045923
Can this be closed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mikemccand commented on issue #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187491522
> I agree that it looks redundant, perhaps it would be better to change the common label prefix from `component` to `module` like `module:core/index`, `module:analysis`, `module:sandbox`? `component` comes from Jira's `Components` field, then it does not really mean that much on GitHub?
+1, I like that solution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta closed issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mocobeta closed issue #53: Remove "module" for core components?
URL: https://github.com/apache/lucene-jira-archive/issues/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #53: Remove "module" for core components?
Posted by GitBox <gi...@apache.org>.
mocobeta commented on issue #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187457057
> Could we remove the `module/` prefix for `core`? It would make the core component strings shorter, which is meaningful/helpful since they are so frequently used?
We can omit `module` from it though, I would slightly prefer to have `module` for all components for consistency. This is a bit longer but we'll use the auto-complete feature when adding/editing labels anyway.
I agree that it looks redundant, perhaps it would be better to change the common label prefix from `component` to `module` like `module:core/index`, `module:analysis`, `module:sandbox`? `component` comes from Jira's `Components` field, then it does not really mean that much on GitHub?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org