You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/01/10 06:40:17 UTC
[Bug 5289] New: sa-learn --use-ignores stops when encountering ignored address
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
Summary: sa-learn --use-ignores stops when encountering ignored
address
Product: Spamassassin
Version: 3.1.7
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Learner
AssignedTo: dev@spamassassin.apache.org
ReportedBy: steffen@ics.mq.edu.au
Running 'sa-learn --use-ignores' on a mailbox with addresses listed as
bayes_ignore_from in my config exits when it first encounters such an address.
I've tracked this down to learn() in Bayes.pm returning 0 instead of 1 when
encountering an ignored address, fixed by the attached patch.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
------- Additional Comments From steffen@ics.mq.edu.au 2007-01-09 21:41 -------
Created an attachment (id=3822)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3822&action=view)
patch to lib/Mail/SpamAssassin/Bayes.pm
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Status Whiteboard|needs 1 vote |ready to commit
------- Additional Comments From felicity@apache.org 2007-02-04 11:42 -------
Sending lib/Mail/SpamAssassin/Bayes.pm
Transmitting file data .
Committed revision 503463.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|sa-learn --use-ignores stops|[review] sa-learn --use-
|when encountering ignored |ignores stops when
|address |encountering ignored address
Target Milestone|Undefined |3.1.8
------- Additional Comments From felicity@apache.org 2007-01-10 11:07 -------
The patch doesn't use the the proper return code -- learn returns 0 for not
learned, and 1 for learned, and the message wasn't learned so 1 isn't correct.
It appears the issue is that learn is returning undef for ignored messages,
instead of 0, which indicates failure, which is bad. Patch forthcoming.
Also, fwiw, the ignores code, which is run by default, in general is very
hackish. We really ought to clean it up -- create a new pms object just to look
at from/to addresses?!? Eeek! I'll have to open a new ticket about that.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3822 is|0 |1
obsolete| |
------- Additional Comments From felicity@apache.org 2007-01-10 11:08 -------
Created an attachment (id=3825)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3825&action=view)
suggested patch
basically the same as 3822 except return a 0 instead of a 1 which is more
accurate.
thanks for catching this. :)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |minor
Status Whiteboard| |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
parkerm@pobox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From parkerm@pobox.com 2007-01-31 20:34 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
------- Additional Comments From jm@jmason.org 2007-02-02 02:50 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5289] [review] sa-learn --use-ignores stops when encountering ignored address
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5289
------- Additional Comments From steffen@ics.mq.edu.au 2007-01-10 14:01 -------
oops, thanks for pointing out the return value should be 0, sorry about that,
got confused about the no-args behaviour of return...
confirming this fixes the problem for me in 3.1.7
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.