You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/31 12:59:41 UTC
[GitHub] [cordova-plugin-camera] PieterVanPoyer opened a new pull request #700: Bugfix issue 665
PieterVanPoyer opened a new pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes #665
Fixes #696
### Description
<!-- Describe your changes in detail -->
In the processResultFromCamera method, the imageFilePath is used.
It was not restored when the activity was destroyd.
So I've added the imageFilePath to the state Bundle in the saveInstance and the restoreInstance methods.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Tested it on an Android 10 emulator
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-769816032
Generally I like to have 2 green checks, but I'll merge sometime Monday assuming there are no objections. Sooner if I get another green check from a PMC member.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek merged pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] PieterVanPoyer commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-766368128
@timbru31 thanks for the review. I did commit your suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] FlossyWeb commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
FlossyWeb commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-781348580
Hi there,
Are you planning to update the npm package anytime soon ?
It would be nice...
Thank you guys
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-771880349
Tests are green, and haven't had any objections so merging!
Thank you for your contribution @PieterVanPoyer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] PieterVanPoyer edited a comment on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer edited a comment on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-766165857
@breautek @erisu maybe it's time to merge this one. And start a release. Some users report that this PR fixes the linked issues.
Kind regards
Pieter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] satheeshkumartitan edited a comment on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
satheeshkumartitan edited a comment on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-849453009
I've also updated the latest plugin 5.0.2, but the same problems occur on Android 10 (device - redmi note 7pro). The plugin 5.0.2. Forcefully close the application once we capture a photo. This happens on some specific devices. Please update the new version I'm waiting for the new version
Node -v ----14.16.0
ionic -v ---- 6.13.1
cordova -v----10.0.0
ionic cordova platform add android@9.1.0
npm i @ionic-native/camera@5.33.0
tested <preference name="android-targetSdkVersion" value="30" /> and <preference name="android-targetSdkVersion" value="29" /> both same crash.
I'm waiting for your response, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] satheeshkumartitan commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
satheeshkumartitan commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-849453009
I've also updated the latest plugin 5.0.2, but the same problems occur on Android 10 (device - redme not 7pro). The plugin 5.0.2. Forcefully close the application once we capture a photo. This happens on some specific devices. Please update the new version I'm waiting for the new version
Node -v ----14.16.0
ionic -v ---- 6.13.1
cordova -v----10.0.0
ionic cordova platform add android@9.1.0
tested <preference name="android-targetSdkVersion" value="30" /> and <preference name="android-targetSdkVersion" value="29" /> both same crash.
I'm waiting for your response, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] PieterVanPoyer commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-766368128
@timbru31 thanks for the review. I did commit your suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] timbru31 commented on a change in pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#discussion_r563216343
##########
File path: src/android/CameraLauncher.java
##########
@@ -1350,6 +1351,10 @@ public Bundle onSaveInstanceState() {
state.putString(IMAGE_URI_KEY, this.imageFilePath);
}
+ if(this.imageFilePath != null) {
Review comment:
```suggestion
if (this.imageFilePath != null) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] PieterVanPoyer commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-753479807
@breautek @jcesarmobile @erisu Is anybody able to review this PR? Kind regards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] PieterVanPoyer commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-769650568
@timbru31 or @breautek can anyone merge this one to the master. Most users report that this PR fixes the linked issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek merged pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] PieterVanPoyer commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-766165857
@breautek @erisu maybe it's time to merge this one. And start a release. Some users report that this PR fixes the linked issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] codeconsole commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
codeconsole commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-803018837
Any chance for a merge or at least a comment on https://github.com/apache/cordova-plugin-camera/pull/712 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek closed pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
breautek closed pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-771880349
Tests are green, and haven't had any objections so merging!
Thank you for your contribution @PieterVanPoyer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jay34fr commented on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
jay34fr commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-857970530
Hi all,
Same issue here.
I updated to 5.0.2 but the app is still restarting after taking and validating a photo.
Cordova 9.0.0
Cordova Android 9.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] satheeshkumartitan edited a comment on pull request #700: Bugfix issue 665
Posted by GitBox <gi...@apache.org>.
satheeshkumartitan edited a comment on pull request #700:
URL: https://github.com/apache/cordova-plugin-camera/pull/700#issuecomment-849453009
I've also updated the latest plugin 5.0.2, but the same problems occur on Android 10 (device - redme not 7pro). The plugin 5.0.2. Forcefully close the application once we capture a photo. This happens on some specific devices. Please update the new version I'm waiting for the new version
Node -v ----14.16.0
ionic -v ---- 6.13.1
cordova -v----10.0.0
ionic cordova platform add android@9.1.0
npm i @ionic-native/camera@5.33.0
tested <preference name="android-targetSdkVersion" value="30" /> and <preference name="android-targetSdkVersion" value="29" /> both same crash.
I'm waiting for your response, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org