You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Leonard Lu (JIRA)" <ji...@apache.org> on 2010/04/15 21:48:49 UTC

[jira] Created: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
-----------------------------------------------------------------------------------------------

                 Key: TAP5-1106
                 URL: https://issues.apache.org/jira/browse/TAP5-1106
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.1.0.5, 5.2.0
            Reporter: Leonard Lu
            Priority: Minor


>From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):

 "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."

All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Posted by "Leonard Lu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858664#action_12858664 ] 

Leonard Lu commented on TAP5-1106:
----------------------------------

onException takes an Ajax.Request instance as its first parameter, not Ajax.Response, therefore line 327 of tapestry.js:
Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);

will result in the cryptic message  "Ajax failure: Status for : [object Object]"

> Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1106
>                 URL: https://issues.apache.org/jira/browse/TAP5-1106
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0, 5.1.0.5
>            Reporter: Leonard Lu
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.2.0
>
>
> From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):
>  "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."
> All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1106.
--------------------------------------

    Fix Version/s: 5.2.0
       Resolution: Fixed

> Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1106
>                 URL: https://issues.apache.org/jira/browse/TAP5-1106
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0, 5.1.0.5
>            Reporter: Leonard Lu
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.2.0
>
>
> From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):
>  "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."
> All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1106:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1106
>                 URL: https://issues.apache.org/jira/browse/TAP5-1106
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0, 5.1.0.5
>            Reporter: Leonard Lu
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>
> From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):
>  "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."
> All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Posted by "Leonard Lu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858664#action_12858664 ] 

Leonard Lu commented on TAP5-1106:
----------------------------------

onException takes an Ajax.Request instance as its first parameter, not Ajax.Response, therefore line 327 of tapestry.js:
Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);

will result in the cryptic message  "Ajax failure: Status for : [object Object]"

> Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1106
>                 URL: https://issues.apache.org/jira/browse/TAP5-1106
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0, 5.1.0.5
>            Reporter: Leonard Lu
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.2.0
>
>
> From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):
>  "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."
> All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1106:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1106
>                 URL: https://issues.apache.org/jira/browse/TAP5-1106
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0, 5.1.0.5
>            Reporter: Leonard Lu
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>
> From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):
>  "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."
> All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-1106) Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1106.
--------------------------------------

    Fix Version/s: 5.2.0
       Resolution: Fixed

> Tapestry.ajaxFailureHandler has an incorrect signature for an Ajax.Request onException callback
> -----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1106
>                 URL: https://issues.apache.org/jira/browse/TAP5-1106
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.0, 5.1.0.5
>            Reporter: Leonard Lu
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.2.0
>
>
> From the Prototype Ajax documentation ( http://api.prototypejs.org/ajax/ ):
>  "onException: Triggered whenever an XHR error arises. Has a custom signature: the first argument is the requester (i.e. an Ajax.Request instance), and the second is the exception object."
> All other callbacks "are invoked with two parameters: the Ajax.Response  object and the result of evaluating the X-JSON response header, if any (can be null)."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.