You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Ankit Agarwal (JIRA)" <ji...@apache.org> on 2016/05/25 15:10:14 UTC

[jira] [Comment Edited] (OAK-4401) Excerpt Highlighting for a property is not correct

    [ https://issues.apache.org/jira/browse/OAK-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300190#comment-15300190 ] 

Ankit Agarwal edited comment on OAK-4401 at 5/25/16 3:09 PM:
-------------------------------------------------------------

[~teofili] [~catholicon]

Attaching Patch file with additional TestCase which IMO should fix the bug. 
Also if we all agree that highlighting "of" from word "official" ("<strong>of</strong>ficial") is incorrect then test case mentioned at [0] will be incorrect. 
Could not create pull req as this test case at [0] is failing after the changes

[0] https://github.com/apache/jackrabbit-oak/blob/ca05fd06f97e4ea2be08b58204c3be060d71e7f0/oak-core/src/test/java/org/apache/jackrabbit/oak/query/fulltext/SimpleExcerptProviderTest.java#L54

cc; [~amitgupt]


was (Author: anagarwa):
[~teofili] [~catholicon]

Attaching Patch file with additional TestCase which IMO should fix the bug. 
Also if we all agree that highlighting "of" from word "official" ("<strong>of</strong>ficial") is incorrect then test case mentioned at [1] will be incorrect. 
Could not create pull req as this test case at [1] is failing after the changes

[0] https://github.com/apache/jackrabbit-oak/blob/ca05fd06f97e4ea2be08b58204c3be060d71e7f0/oak-core/src/test/java/org/apache/jackrabbit/oak/query/fulltext/SimpleExcerptProviderTest.java#L54

cc; [~amitgupt]

> Excerpt Highlighting for a property is not correct 
> ---------------------------------------------------
>
>                 Key: OAK-4401
>                 URL: https://issues.apache.org/jira/browse/OAK-4401
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>    Affects Versions: 1.5.2
>            Reporter: Ankit Agarwal
>         Attachments: 0001-OAK-4401-Excerpt-Highlighting-for-a-property-is-not-.patch
>
>
> if we have following text at property 
> /jcr:content/text
> ===
> A state agency’s Conflict of Interest Code must reflect the current structure of the organization and properly identify officials andemployees
> =====
> and if rep:excerpt(/jcr:content/text) is been calling after search then 
> ==============
> <strong>of</strong>ficials will be in output , which is incorrect.
> ==============



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)