You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/11/12 15:36:23 UTC
[GitHub] incubator-brooklyn pull request: location is not serializable
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1023
location is not serializable
Deletes `extends Serializable` from location interface, and removes all declared serialVersionUID from location implementations.
Location was not really serialisable anyway - for example it had non-transient references to `ManagementContext`. The declaration of “Serializable” was a throwback to very old days when persistence was imagined to be very different.
Also has some other very minor tidy up (in separate commits).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn refactor/location-not-serializable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1023.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1023
----
commit 055940f2127fbfd52dd6b48251901fc45e39736b
Author: Aled Sage <al...@gmail.com>
Date: 2015-11-12T14:17:12Z
Location is not serializable
Deletes “extends Serializable” from location interface, and removes
all declared serialVersionUID from location implementations.
Location was not really serialisable anyway - for example it had
non-transient references to ManagementContext. The declaration of
“Serializable” was a throwback to very old days when persistence
was imagined to be very different.
commit 484d9d4bcba9f89c63e5729cbe6037966bff095b
Author: Aled Sage <al...@gmail.com>
Date: 2015-11-12T14:19:35Z
AttributeMap is not serializable
It doesn’t need to be serialisable; and it contains a non-transient
field of type AbstractEntity so wasn’t really serializable anyway.
commit ae7532c61c737410576db9a60ce89b2fa6cd715b
Author: Aled Sage <al...@gmail.com>
Date: 2015-11-12T14:34:17Z
Fix some trivial compiler warnings
commit 7d3f2efefcaa50af08b13b771c8dc92286171e67
Author: Aled Sage <al...@gmail.com>
Date: 2015-11-12T14:34:39Z
IptablesCommandsTest: focus on non-deprecated methods
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: location is not serializable
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1023#issuecomment-156296619
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: location is not serializable
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---