You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jatin9896 <gi...@git.apache.org> on 2018/03/14 08:55:43 UTC
[GitHub] carbondata pull request #2063: [CARBONDATA-2251] Refactored sdv testcase
GitHub user jatin9896 opened a pull request:
https://github.com/apache/carbondata/pull/2063
[CARBONDATA-2251] Refactored sdv testcase
1. MergeIndex test case in sdv fails if executed with a different number of executors or in standalone spark.
2. Changes test case having Hive UDAF like histogram_numeric having unexpected behavior. so recommended way to write test cases using aggregation.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? No
- [ ] Any backward compatibility impacted? No
- [ ] Document update required? No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jatin9896/incubator-carbondata CARBONDATA-2251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2063.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2063
----
commit 6de85846874821cfa0e18027da8beb56ca269cf6
Author: Jatin <ja...@...>
Date: 2018-03-13T11:43:13Z
Refactored sdv testcase
----
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3955/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2063
retest sdv please
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3107/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2063
LGTM...can be merged once SDV build is success
---
[GitHub] carbondata pull request #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2063
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3650/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4341/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5097/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2063
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4560/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3187/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2063
retest sdv please
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2063
retest sdv please
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2063
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3904/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4421/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2063
retest sdv please
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2063
LGTM
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2063
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3944/
---
[GitHub] carbondata pull request #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2063#discussion_r175361959
--- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/MergeIndexTestCase.scala ---
@@ -45,7 +45,7 @@ class MergeIndexTestCase extends QueryTest with BeforeAndAfterAll {
sql(s"""create table carbon_automation_nonmerge (imei string,deviceInformationId int,MAC string,deviceColor string,device_backColor string,modelId string,marketName string,AMSize string,ROMSize string,CUPAudit string,CPIClocked string,series string,productionDate timestamp,bomCode string,internalModels string, deliveryTime string, channelsId string, channelsName string , deliveryAreaId string, deliveryCountry string, deliveryProvince string, deliveryCity string,deliveryDistrict string, deliveryStreet string, oxSingleNumber string, ActiveCheckTime string, ActiveAreaId string, ActiveCountry string, ActiveProvince string, Activecity string, ActiveDistrict string, ActiveStreet string, ActiveOperatorId string, Active_releaseId string, Active_EMUIVersion string, Active_operaSysVersion string, Active_BacVerNumber string, Active_BacFlashVer string, Active_webUIVersion string, Active_webUITypeCarrVer string,Active_webTypeDataVerNumber string, Active_operatorsVersion string, Active_ph
onePADPartitionedVersions string, Latest_YEAR int, Latest_MONTH int, Latest_DAY int, Latest_HOUR string, Latest_areaId string, Latest_country string, Latest_province string, Latest_city string, Latest_district string, Latest_street string, Latest_releaseId string, Latest_EMUIVersion string, Latest_operaSysVersion string, Latest_BacVerNumber string, Latest_BacFlashVer string, Latest_webUIVersion string, Latest_webUITypeCarrVer string, Latest_webTypeDataVerNumber string, Latest_operatorsVersion string, Latest_phonePADPartitionedVersions string, Latest_operatorId string, gamePointDescription string,gamePointId double,contractNumber double) STORED BY 'org.apache.carbondata.format' TBLPROPERTIES ('DICTIONARY_INCLUDE'='deviceInformationId,Latest_YEAR,Latest_MONTH,Latest_DAY')""").collect
sql(s"""LOAD DATA INPATH '$resourcesPath/Data/VmaLL100' INTO TABLE carbon_automation_nonmerge OPTIONS('DELIMITER'=',','QUOTECHAR'='"','FILEHEADER'='imei,deviceInformationId,MAC,deviceColor,device_backColor,modelId,marketName,AMSize,ROMSize,CUPAudit,CPIClocked,series,productionDate,bomCode,internalModels,deliveryTime,channelsId,channelsName,deliveryAreaId,deliveryCountry,deliveryProvince,deliveryCity,deliveryDistrict,deliveryStreet,oxSingleNumber,contractNumber,ActiveCheckTime,ActiveAreaId,ActiveCountry,ActiveProvince,Activecity,ActiveDistrict,ActiveStreet,ActiveOperatorId,Active_releaseId,Active_EMUIVersion,Active_operaSysVersion,Active_BacVerNumber,Active_BacFlashVer,Active_webUIVersion,Active_webUITypeCarrVer,Active_webTypeDataVerNumber,Active_operatorsVersion,Active_phonePADPartitionedVersions,Latest_YEAR,Latest_MONTH,Latest_DAY,Latest_HOUR,Latest_areaId,Latest_country,Latest_province,Latest_city,Latest_district,Latest_street,Latest_releaseId,Latest_EMUIVersion,Latest_ope
raSysVersion,Latest_BacVerNumber,Latest_BacFlashVer,Latest_webUIVersion,Latest_webUITypeCarrVer,Latest_webTypeDataVerNumber,Latest_operatorsVersion,Latest_phonePADPartitionedVersions,Latest_operatorId,gamePointId,gamePointDescription')""").collect
- assert(getIndexFileCount("default", "carbon_automation_nonmerge", "0") == 2)
--- End diff --
assert getIndexFileCount for > 0
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4872/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2063
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3945/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5165/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2063
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4547/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3188/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4422/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2063
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3875/
---
[GitHub] carbondata issue #2063: [CARBONDATA-2251] Refactored sdv testcase
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2063
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4341/
---