[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2499: Add metrics for ParquetExec

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2499:
URL: https://github.com/apache/arrow-datafusion/pull/2499#discussion_r869306017


##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -227,6 +228,7 @@ impl ExecutionPlan for ParquetExec {
             files: self.base_config.file_groups[partition_index].clone().into(),
             projector: partition_col_proj,
             adapter: SchemaAdapter::new(self.base_config.file_schema.clone()),
+            baseline_metrics: BaselineMetrics::new(&self.metrics, partition_index),
         };
 
         // Use spawn_blocking only if running from a tokio context (#2201)

Review Comment:
   I think the issue is that the `ParquetExecStream` is not yet used by default (#2201) (#2202) by @tustvold 
   
   I think you also have to add code that updates the row count in the code below that creates a `RecordBatchReceiverStream`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org