You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/07/16 03:43:02 UTC
Review Request 12566: Fix NPE when getting resource count
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12566/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and Sheng Yang.
Bugs: CLOUDSTACK-3514
Repository: cloudstack-git
Description
-------
This fix is for an NPE encountered during automation test runs. The NPE showed up in the code that queries resource counts by domain/account id. I was unable to reproduce this in manual testing, but the code definitely needs to be changed to protect against the NPE, so I'm submitting this patch nevertheless. If it is checked in, QA can proceed with their testing. Hence requesting that this patch be checked in.
Diffs
-----
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d
Diff: https://reviews.apache.org/r/12566/diff/
Testing
-------
Issue non-reproducible during manual testing.
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request 12566: Fix NPE when getting resource count
Posted by Sheng Yang <sh...@yasker.org>.
> On July 16, 2013, 11:13 p.m., Sheng Yang wrote:
> > Ship It!
Committed to 4.2 and MASTER.
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12566/#review23208
-----------------------------------------------------------
On July 16, 2013, 1:43 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12566/
> -----------------------------------------------------------
>
> (Updated July 16, 2013, 1:43 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-3514
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This fix is for an NPE encountered during automation test runs. The NPE showed up in the code that queries resource counts by domain/account id. I was unable to reproduce this in manual testing, but the code definitely needs to be changed to protect against the NPE, so I'm submitting this patch nevertheless. If it is checked in, QA can proceed with their testing. Hence requesting that this patch be checked in.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d
>
> Diff: https://reviews.apache.org/r/12566/diff/
>
>
> Testing
> -------
>
> Issue non-reproducible during manual testing.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request 12566: Fix NPE when getting resource count
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12566/#review23208
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On July 16, 2013, 1:43 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12566/
> -----------------------------------------------------------
>
> (Updated July 16, 2013, 1:43 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-3514
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This fix is for an NPE encountered during automation test runs. The NPE showed up in the code that queries resource counts by domain/account id. I was unable to reproduce this in manual testing, but the code definitely needs to be changed to protect against the NPE, so I'm submitting this patch nevertheless. If it is checked in, QA can proceed with their testing. Hence requesting that this patch be checked in.
>
>
> Diffs
> -----
>
> server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d
>
> Diff: https://reviews.apache.org/r/12566/diff/
>
>
> Testing
> -------
>
> Issue non-reproducible during manual testing.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>