You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/14 01:06:46 UTC
[GitHub] [airflow] yuqian90 opened a new pull request #7415: [AIRFLOW-6800]
Close file object after parsing ssh config
yuqian90 opened a new pull request #7415: [AIRFLOW-6800] Close file object after parsing ssh config
URL: https://github.com/apache/airflow/pull/7415
This line of code in ssh/hooks.py is opening a file object without closing it in the scope where it is opened.
This causes unnecessary noise e.g. when py.test warns about unclosed file objects. This PR fixes it by making sure file object is closed properly.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x ] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7415: [AIRFLOW-6800] Close
file object after parsing ssh config
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7415: [AIRFLOW-6800] Close file object after parsing ssh config
URL: https://github.com/apache/airflow/pull/7415#issuecomment-586149010
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=h1) Report
> Merging [#7415](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ed2f3dc4ca28609bcead681f95b6e26e13d64c28?src=pr&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7415 +/- ##
=========================================
- Coverage 86.52% 86.32% -0.2%
=========================================
Files 874 874
Lines 40920 40921 +1
=========================================
- Hits 35406 35326 -80
- Misses 5514 5595 +81
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `87.71% <0%> (-0.78%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.34% <0%> (+0.43%)` | :arrow_up: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `94.36% <0%> (+16.9%)` | :arrow_up: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `85.29% <0%> (+32.35%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7415/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=footer). Last update [ed2f3dc...91ce002](https://codecov.io/gh/apache/airflow/pull/7415?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7415: [AIRFLOW-6800] Close
file object after parsing ssh config
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7415: [AIRFLOW-6800] Close file object after parsing ssh config
URL: https://github.com/apache/airflow/pull/7415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7415: [AIRFLOW-6800] Close
file object after parsing ssh config
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7415: [AIRFLOW-6800] Close file object after parsing ssh config
URL: https://github.com/apache/airflow/pull/7415#issuecomment-586128226
Travis is sad. I restarted a failed job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services