[GitHub] [lucene] rmuir commented on a diff in pull request #11938: fix overflows in compound assignments

[GitBox <gi...@apache.org>]

rmuir commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1023927808


##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##########
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
   protected static class MergedVectorValues extends VectorValues {
     private final List<VectorValuesSub> subs;
     private final DocIDMerger<VectorValuesSub> docIdMerger;
-    private final int cost;
+    private final long cost;

Review Comment:
   i didn't look at how it was used, only doing shallow cleanups here. it is exposed via `long cost()` method, so it never made sense to be an int. what would `cost()` return instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org