You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "solrbot (via GitHub)" <gi...@apache.org> on 2025/01/24 00:39:36 UTC
[PR] chore(deps): update eclipse.jetty to v10.0.24 [solr]
solrbot opened a new pull request, #3071:
URL: https://github.com/apache/solr/pull/3071
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.eclipse.jetty:jetty-xml](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-webapp](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-util](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-start](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-servlets](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-servlet](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-server](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-security](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-rewrite](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-jmx](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-io](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty.http2:http2-server](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty.http2:http2-http-client-transport](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty.http2:http2-hpack](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty.http2:http2-common](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty.http2:http2-client](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-http](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-deploy](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-client](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-alpn-server](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-alpn-java-server](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
| [org.eclipse.jetty:jetty-alpn-java-client](https://jetty.org) ([source](https://redirect.github.com/jetty/jetty.project)) | dependencies | patch | `10.0.22` -> `10.0.24` |
---
### Configuration
📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action)
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjQuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on PR #3071:
URL: https://github.com/apache/solr/pull/3071#issuecomment-3265280703
Closing this one in favor of https://github.com/apache/solr/pull/3616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "solrbot (via GitHub)" <gi...@apache.org>.
solrbot commented on PR #3071:
URL: https://github.com/apache/solr/pull/3071#issuecomment-3197693119
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
- any of the package files in this branch needs updating, or
- the branch becomes conflicted, or
- you click the rebase/retry checkbox if found above, or
- you rename this PR's title to start with "rebase!" to trigger it manually
The artifact failure details are included below:
##### File name: undefined
```
Command failed: ./gradlew updateLicenses
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/tmp/renovate/repos/github/apache/solr/solr/core/src/java/org/apache/solr/core/SolrCore.java:533: warning: [removal] RuntimeIOException in org.eclipse.jetty.io has been deprecated and marked for removal
throw new RuntimeIOException(e);
^
error: warnings found and -Werror specified
/tmp/renovate/repos/github/apache/solr/solr/core/src/java/org/apache/solr/handler/CatStream.java:252: warning: [removal] RuntimeIOException in org.eclipse.jetty.io has been deprecated and marked for removal
throw new RuntimeIOException(e);
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
2 warnings
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':solr:core:compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
> Run with --info option to get more log output.
BUILD FAILED in 41s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay closed pull request #3071: Update eclipse.jetty
URL: https://github.com/apache/solr/pull/3071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "solrbot (via GitHub)" <gi...@apache.org>.
solrbot commented on PR #3071:
URL: https://github.com/apache/solr/pull/3071#issuecomment-3248292627
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ **Warning**: custom changes will be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3071:
URL: https://github.com/apache/solr/pull/3071#discussion_r2318149096
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientCompatibilityTest.java:
##########
@@ -36,11 +36,13 @@ public class Http2SolrClientCompatibilityTest extends SolrJettyTestBase {
public void testSystemPropertyFlag() {
System.setProperty("solr.http1", "true");
try (Http2SolrClient client = new Http2SolrClient.Builder().build()) {
- assertTrue(client.getHttpClient().getTransport() instanceof HttpClientTransportOverHTTP);
+ assertTrue(
+ client.getHttpClient().getHttpClientTransport() instanceof HttpClientTransportOverHTTP);
Review Comment:
The API change from getTransport() to getHttpClientTransport() suggests a breaking change in Jetty 12.1.0. Ensure this change is documented in release notes and verify that all other code using the old API has been updated.
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -530,7 +530,7 @@ public int getSegmentCount() {
return withSearcher(
solrIndexSearcher -> solrIndexSearcher.getRawReader().getIndexCommit().getSegmentCount());
} catch (IOException e) {
- throw new RuntimeIOException(e);
+ throw new UncheckedIOException(e);
Review Comment:
The replacement of RuntimeIOException with UncheckedIOException is correct as RuntimeIOException was likely removed from Jetty 12.1.0. However, verify that the behavior is identical - both are runtime exceptions that wrap IOException.
##########
solr/core/build.gradle:
##########
@@ -119,7 +119,6 @@ dependencies {
implementation libs.eclipse.jetty.client
implementation libs.eclipse.jetty.http
Review Comment:
The removal of explicit jetty-io dependency suggests it's now transitively included. Verify that this doesn't cause issues with dependency resolution or that the required classes are still available at runtime.
```suggestion
implementation libs.eclipse.jetty.http
implementation libs.eclipse.jetty.io
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on code in PR #3071:
URL: https://github.com/apache/solr/pull/3071#discussion_r2318166306
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientCompatibilityTest.java:
##########
@@ -36,11 +36,13 @@ public class Http2SolrClientCompatibilityTest extends SolrJettyTestBase {
public void testSystemPropertyFlag() {
System.setProperty("solr.http1", "true");
try (Http2SolrClient client = new Http2SolrClient.Builder().build()) {
- assertTrue(client.getHttpClient().getTransport() instanceof HttpClientTransportOverHTTP);
+ assertTrue(
+ client.getHttpClient().getHttpClientTransport() instanceof HttpClientTransportOverHTTP);
Review Comment:
in 12.0.19
```
public HttpClientTransport getTransport()
{
return transport;
}
```
in 12.1.0
```
/**
* @deprecated use {@link #getHttpClientTransport()} instead
*/
@Deprecated(forRemoval = true, since = "12.1.0")
public HttpClientTransport getTransport()
{
return getHttpClientTransport();
}
/**
* @return the {@link HttpClientTransport} associated with this {@code HttpClient}
*/
public HttpClientTransport getHttpClientTransport()
{
return transport;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on PR #3071:
URL: https://github.com/apache/solr/pull/3071#issuecomment-3248209296
Reproduce with: ./gradlew :solr:solrj:test --tests "org.apache.solr.client.solrj.impl.BasicHttpSolrClientTest.testQuery" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=854740335AA6CB74 -Ptests.useSecurityManager=true -Ptests.file.encoding=UTF-8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on code in PR #3071:
URL: https://github.com/apache/solr/pull/3071#discussion_r2318177399
##########
solr/core/build.gradle:
##########
@@ -119,7 +119,6 @@ dependencies {
implementation libs.eclipse.jetty.client
implementation libs.eclipse.jetty.http
Review Comment:
org.eclipse.jetty.io.RuntimeIOException; was being used by core and RuntimeIOException is deprecated. Instead using UncheckedIOException which is part of java package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Update eclipse.jetty [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on PR #3071:
URL: https://github.com/apache/solr/pull/3071#issuecomment-3249663192
This seems to be a big change in terms of things it's affecting -- still few test cases are failing. Starting to think if going to 12.0.25 is better option in compare to 12.1.0 jetty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org