You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "guoshupei (via GitHub)" <gi...@apache.org> on 2023/08/02 08:51:43 UTC
[GitHub] [linkis] guoshupei commented on a diff in pull request #4784: feat: "spark-submit jar on k8s" related label and resource expansion
guoshupei commented on code in PR #4784:
URL: https://github.com/apache/linkis/pull/4784#discussion_r1281598182
##########
linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/java/org/apache/linkis/manager/rm/service/RequestResourceService.java:
##########
@@ -404,7 +403,61 @@ public Pair<Integer, String> generateNotEnoughMessage(
return generateNotEnoughMessage(
dy.getYarnResource(), dyAvailable.getYarnResource(), dyMax.getYarnResource());
}
-
+ } else if (requestResource instanceof KubernetesResource) {
+ KubernetesResource kubernetesResource = (KubernetesResource) requestResource;
+ KubernetesResource kubernetesResourceAvailable = (KubernetesResource) availableResource;
+ KubernetesResource kubernetesResourceMax = (KubernetesResource) maxResource;
+ if (kubernetesResource.getCores() > kubernetesResourceAvailable.getCores()) {
+ return Pair.of(
+ RMErrorCode.NAMESPACE_CPU_INSUFFICIENT.getErrorCode(),
+ RMErrorCode.NAMESPACE_CPU_INSUFFICIENT.getErrorDesc()
+ + RMUtils.getResourceInfoMsg(
+ RMConstant.CPU,
+ RMConstant.KUBERNETES_CPU_UNIT,
+ kubernetesResource.getCores(),
+ kubernetesResourceAvailable.getCores(),
+ kubernetesResourceMax.getCores()));
+ } else if (kubernetesResource.getMemory() > kubernetesResource.getMemory()) {
Review Comment:
change to "kubernetesResource.getMemory() > kubernetesResourceAvailable.getMemory()"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org