You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/03/04 12:56:07 UTC

[Bug 6365] New: need way to cut emergency rule updates with new update-generation system

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

           Summary: need way to cut emergency rule updates with new
                    update-generation system
           Product: Spamassassin
           Version: 3.3.0
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: P5
         Component: sa-update
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: jm@jmason.org


split off from bug 6363.

we urgently need to have a way to cut an update package from current SVN,
without having to go through the full mass-check/score-generation daily cycle. 
CUrrently it appears that the
/export/home/updatesd/svn/mkupdates-with-scores/do-stable-update-with-scores
script is oriented towards full generation and doesn't allow that.

this ticket is to track that work.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #2 from Justin Mason <jm...@jmason.org> 2010-03-04 14:25:27 UTC ---
(In reply to comment #1)
> Kind'a duplicate for Bug 6281 too.

there's overlap, but it's not a dup.  Bug 6281 deals with speeding up the
pipeline in the normal case -- this is for the emergency-change case, where the
manually-made change needs to go out ASAP.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Daryl C. W. O'Shea <sp...@dostech.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.2                       |3.3.3

--- Comment #13 from Daryl C. W. O'Shea <sp...@dostech.ca> 2011-05-28 17:40:28 UTC ---
Retargetting to 3.3.3 so it stays on my radar.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P4
   Target Milestone|3.4.0                       |3.4.1

--- Comment #15 from Kevin A. McGrail <km...@pccc.com> 2011-10-28 21:39:37 UTC ---
Retargeting to 3.4.1 to release 3.4.0.  However, this should get fixed before
the next time when it's needed in a pinch.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2

--- Comment #6 from Justin Mason <jm...@jmason.org> 2010-03-12 14:41:33 UTC ---
this is important, but doesn't need to block 3.3.1.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #12 from Kevin A. McGrail <km...@pccc.com> 2011-05-28 10:28:36 UTC ---
(In reply to comment #11)
> I've added a script to revert to an existing update version...
> build/mkupdates/revert-stable-update
> 
> It doesn't solve the problem of making a fast new update, but it does give us
> the option of easily rolling back (reverting) to a previous update version.
> 
> Reverting to an existing generally known to be good update should be our number
> one choice when trying to correct a rule update problem as were not rushing out
> a new update that could be broken in its own way.  This works in cases where a
> new update introduces a problem, such as a new really bad rule.
> 
> It doesn't help us in situation where an old rule turns bad for some reason,
> such as our little "Y2K10" rule issue from January 1 last year.  In cases such
> as those (which I expect to be much fewer in occurence then the "new bad
> update" described above) we'll need to create and release a new update.  I'll
> work on this case next.  I think one possible way I may do it is that you
> supply a patch to the revert script for it to apply to an existing update (the
> script would unpack the existing update, patch it, pack it back up and re-sign
> it).

I consider this solution as a good interim measure suitable to move this bug to
a target of 3.4.0.  Do you agree?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #4 from Justin Mason <jm...@jmason.org> 2010-03-05 11:32:49 UTC ---
there's another use-case for this script.  When a release is pushed, we need to
simultaneously push a rule update package.  Currently there's no easy way to do
that for 3.3.x.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Daryl C. W. O'Shea <sp...@dostech.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spamassassin@dostech.ca

--- Comment #11 from Daryl C. W. O'Shea <sp...@dostech.ca> 2011-05-20 05:37:40 UTC ---
I've added a script to revert to an existing update version...
build/mkupdates/revert-stable-update

It doesn't solve the problem of making a fast new update, but it does give us
the option of easily rolling back (reverting) to a previous update version.

Reverting to an existing generally known to be good update should be our number
one choice when trying to correct a rule update problem as were not rushing out
a new update that could be broken in its own way.  This works in cases where a
new update introduces a problem, such as a new really bad rule.

It doesn't help us in situation where an old rule turns bad for some reason,
such as our little "Y2K10" rule issue from January 1 last year.  In cases such
as those (which I expect to be much fewer in occurence then the "new bad
update" described above) we'll need to create and release a new update.  I'll
work on this case next.  I think one possible way I may do it is that you
supply a patch to the revert script for it to apply to an existing update (the
script would unpack the existing update, patch it, pack it back up and re-sign
it).

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #3 from Daryl C. W. O'Shea <sp...@dostech.ca> 2010-03-05 01:22:25 UTC ---
I'm thinking about how'd I'd like to see this improved.

In the meantime, one easy way to do this is to just unpack the latest generated
revision, apply your diff and repackage it by hand.  Update the zone file, wait
16 minutes (or until the update appears on mirrors) and tick the zone serial
number.

Something in my head is screaming don't just use the current revision's rules. 
I guess it's safe if you audit any changes in the rules from the previous 48+
hours.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Warren Togami <wt...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wtogami@gmail.com

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Libraries                   |sa-update

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #8 from Justin Mason <jm...@jmason.org> 2010-03-22 12:23:30 UTC ---
(In reply to comment #4)
> there's another use-case for this script.  When a release is pushed, we need to
> simultaneously push a rule update package.  Currently there's no easy way to do
> that for 3.3.x.

well, this part is fixed; I used the "update-rules-3.3" script to do that and
updated the procedure during the 3.3.1 release, see bug 6311.

I'm pretty sure that script will work fine as an emergency-update-generation
script.  I'd just like to verify that there's no major functionality in the
mass-check/score-generation cron scripts that doesn't also need to be
duplicated for this case.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-03-04 13:24:09 UTC ---
> split off from bug 6363.
> we urgently need to have a way to cut an update package from current SVN,
> without having to go through the full mass-check/score-generation daily cycle. 

Kind'a duplicate for Bug 6281 too.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #5 from Justin Mason <jm...@jmason.org> 2010-03-12 14:13:38 UTC ---
(btw, I'm re-enabling the "nightly stable update from trunk" cron job at the
moment.)

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

--- Comment #7 from Justin Mason <jm...@jmason.org> 2010-03-15 11:13:08 UTC ---
I think the script from bug 6311 ("build/mkupdates/update-rules-3.3") should be
enough to fix this....

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P1
                 CC|                            |jm@jmason.org
   Target Milestone|Undefined                   |3.3.1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|security                    |
          Component|Security                    |Libraries
         AssignedTo|security@spamassassin.apach |dev@spamassassin.apache.org
                   |e.org                       |

--- Comment #10 from Karsten Bräckelmann <gu...@rudersport.de> 2010-03-23 17:42:56 UTC ---
Moving back off of Security, which got changed by accident during the mass
Target Milestone move.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6365] need way to cut emergency rule updates with new update-generation system

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6365

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.3                       |3.4.0

--- Comment #14 from Mark Martinec <Ma...@ijs.si> 2011-09-23 23:44:44 UTC ---
Retargetting to 3.4.0, now that 3.3.3 is off the scope.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.