You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2025/11/19 06:44:07 UTC
[PR] Support to inject environment variables for spark/flink submit [amoro]
turboFei opened a new pull request, #3954:
URL: https://github.com/apache/amoro/pull/3954
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #xxx.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3955] Support to inject environment variables for spark/flink submit [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3954:
URL: https://github.com/apache/amoro/pull/3954#issuecomment-3559505843
seems it is already supported, closed this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3955] Support to inject environment variables for spark/flink submit [amoro]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3954:
URL: https://github.com/apache/amoro/pull/3954#issuecomment-3551239334
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3954?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `44.44444%` with `10 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 28.95%. Comparing base ([`12e7946`](https://app.codecov.io/gh/apache/amoro/commit/12e7946d6aed7d5df7619e09b48ea5cd475743d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`54f4d05`](https://app.codecov.io/gh/apache/amoro/commit/54f4d05a57acfa70e4644cfdb0f54444a0a43b74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/amoro/pull/3954?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../amoro/server/manager/FlinkOptimizerContainer.java](https://app.codecov.io/gh/apache/amoro/pull/3954?src=pr&el=tree&filepath=amoro-ams%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2Fmanager%2FFlinkOptimizerContainer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9hbW9yby9zZXJ2ZXIvbWFuYWdlci9GbGlua09wdGltaXplckNvbnRhaW5lci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3954?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../amoro/server/manager/SparkOptimizerContainer.java](https://app.codecov.io/gh/apache/amoro/pull/3954?src=pr&el=tree&filepath=amoro-ams%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fserver%2Fmanager%2FSparkOptimizerContainer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tYW1zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9hbW9yby9zZXJ2ZXIvbWFuYWdlci9TcGFya09wdGltaXplckNvbnRhaW5lci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3954?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3954 +/- ##
============================================
- Coverage 29.03% 28.95% -0.09%
+ Complexity 3862 3861 -1
============================================
Files 634 630 -4
Lines 50808 50621 -187
Branches 6545 6463 -82
============================================
- Hits 14753 14655 -98
+ Misses 34997 34934 -63
+ Partials 1058 1032 -26
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/3954/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core](https://app.codecov.io/gh/apache/amoro/pull/3954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `28.95% <44.44%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3954?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3955] Support to inject environment variables for spark/flink submit [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3954:
URL: https://github.com/apache/amoro/pull/3954#issuecomment-3553818626
Hi @klion26
It is helpful for spark/flink submit to transfer some engine env.
Simliar implementation:
https://github.com/apache/kyuubi/blob/5887e76c26f9ca9b96fd6eeda9cb534e044bdb11/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala#L149-L155
https://github.com/apache/kyuubi/blob/master/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
https://github.com/apache/kyuubi/blob/master/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3955] Support to inject environment variables for spark/flink submit [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #3954: [AMORO-3955] Support to inject environment variables for spark/flink submit
URL: https://github.com/apache/amoro/pull/3954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org