You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Vinay (JIRA)" <ji...@apache.org> on 2012/10/11 10:19:03 UTC

[jira] [Created] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Vinay created HDFS-4038:
---------------------------

             Summary: Override toString() for BookKeeperEditLogInputStream
                 Key: HDFS-4038
                 URL: https://issues.apache.org/jira/browse/HDFS-4038
             Project: Hadoop HDFS
          Issue Type: Sub-task
    Affects Versions: 3.0.0, 2.0.2-alpha
            Reporter: Vinay
            Assignee: Vinay
            Priority: Minor


Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497084#comment-13497084 ] 

Hudson commented on HDFS-4038:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1257 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1257/])
    HDFS-4038. Override toString() for BookKeeperEditLogInputStream. Contributed by Vinay. (Revision 1409071)

     Result = FAILURE
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409071
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java

                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474069#comment-13474069 ] 

Hadoop QA commented on HDFS-4038:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548714/HDFS-4038.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3314//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3314//console

This message is automatically generated.
                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Vinay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinay updated HDFS-4038:
------------------------

    Attachment: HDFS-4038.patch

Attaching the patch. 
                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uma Maheswara Rao G updated HDFS-4038:
--------------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.3-alpha
                      3.0.0
    Target Version/s: 2.0.2-alpha, 3.0.0  (was: 3.0.0, 2.0.2-alpha)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

I have committed this to trunk and branch-2. Thanks a lot, Vinay.
                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497012#comment-13497012 ] 

Hudson commented on HDFS-4038:
------------------------------

Integrated in Hadoop-Yarn-trunk #36 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/36/])
    HDFS-4038. Override toString() for BookKeeperEditLogInputStream. Contributed by Vinay. (Revision 1409071)

     Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409071
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java

                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496834#comment-13496834 ] 

Hudson commented on HDFS-4038:
------------------------------

Integrated in Hadoop-trunk-Commit #3013 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3013/])
    HDFS-4038. Override toString() for BookKeeperEditLogInputStream. Contributed by Vinay. (Revision 1409071)

     Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409071
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java

                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474391#comment-13474391 ] 

Uma Maheswara Rao G commented on HDFS-4038:
-------------------------------------------

+1 for the patch Vinay. I will commit it in some time.
                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Vinay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinay updated HDFS-4038:
------------------------

    Status: Patch Available  (was: Open)
    
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4038) Override toString() for BookKeeperEditLogInputStream

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497064#comment-13497064 ] 

Hudson commented on HDFS-4038:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1226 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1226/])
    HDFS-4038. Override toString() for BookKeeperEditLogInputStream. Contributed by Vinay. (Revision 1409071)

     Result = FAILURE
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409071
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperEditLogInputStream.java

                
> Override toString() for BookKeeperEditLogInputStream
> ----------------------------------------------------
>
>                 Key: HDFS-4038
>                 URL: https://issues.apache.org/jira/browse/HDFS-4038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HDFS-4038.patch
>
>
> Override toString() for BookKeeperEditLogInputStream and also avoid lh.toString() in BookKeeperEditLogInputStream#getName() which will log just hashCode

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira