You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Maxim Muzafarov (JIRA)" <ji...@apache.org> on 2019/08/16 10:42:02 UTC
[jira] [Commented] (IGNITE-12077) Improve Checkstyle or other
inspections profile to avoid using GG- reference in Ignite code base
[ https://issues.apache.org/jira/browse/IGNITE-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908957#comment-16908957 ]
Maxim Muzafarov commented on IGNITE-12077:
------------------------------------------
Huge +1
But imagine if some workaround of checking pattern [GG-XXXXX] will be used? I'd suggest allowing and check only such patterns:
1. @Ignore("https://issues.apache.org/jira/browse/IGNITE-XXXXX") - Ignoring tests only with link to an Ignite issue
2. // TODO IGNITE-XXXXX Message about what is needed - Todo comments only with link to an Ignite issue
> Improve Checkstyle or other inspections profile to avoid using GG- reference in Ignite code base
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-12077
> URL: https://issues.apache.org/jira/browse/IGNITE-12077
> Project: Ignite
> Issue Type: Test
> Reporter: Dmitriy Pavlov
> Priority: Major
>
> Time to time tests are Ignored or todo added with reference to
> GG- tickets "
> For example here
> https://github.com/apache/ignite/pull/6748/files#diff-2dd1dad039cddd36610c62a3dc2c1a28R223
> It is suggested to add some inspection check on TC to reject patches if there is a line
> containing:
> - ": //ggsystems.atlassian.net/"
> - or at the same time Ignore or todo and "GG- [0-9] *"
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)