[GitHub] HeartSaVioR commented on a change in pull request #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#discussion_r249944381
 
 

 ##########
 File path: docs/running-on-yarn.md
 ##########
 @@ -472,6 +472,36 @@ To use a custom metrics.properties for the application master and executors, upd
 </tr>
 </table>
 
+#### Available patterns for SHS custom executor log URL
+
+<table class="table">
 
 Review comment:
   I just gave it a try but found one thing which blocks me pointing JHS URL. I have no idea where port `25454` in JHS URL came from.
   
   * NM URL
   
   ```
   http://<node-host>:8042/node/containerlogs/container_e01_1547723113049_0010_01_000001/spark/stdout?start=-4096
   ```
   
   * JHS URL
   
   ```
   http://<job-history-server-host>:19888/jobhistory/logs/<node-host>:25454/container_e01_1547723113049_0010_01_000001/container_e01_1547723113049_0010_01_000001/spark/stdout?start=-4096
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org