[jira] [Resolved] (CALCITE-3486) In JDBC adapter, when generating ROW value expression, generates the ROW keyword only if the dialect allows it

["Danny Chen (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Danny Chen resolved CALCITE-3486.
---------------------------------
      Assignee: Danny Chen
    Resolution: Fixed

Fixed in [ce0118b|https://github.com/apache/calcite/commit/ce0118b4149eb303813d0af2537a7185e9945115], thanks for your PR, [~quxiucheng] !

> In JDBC adapter, when generating ROW value expression, generates the ROW keyword only if the dialect allows it
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3486
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3486
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: quxiucheng
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: next
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> when we use mysql dialect unparse sql,the Mysql dialect does not have a ROW keyword,
> but the ROW keyword does exist in SQL
> SQL
> {code:java}
> insert into emps values (1,'Fredkin')
> {code}
> SqlNode.toString(MysqlSqlDialect.DEFAULT)
> {code:java}
> insert into emps values ROW(1,'Fredkin')
> {code}
> This syntax is problematic in mysql
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)