You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/27 16:36:13 UTC

[GitHub] [geode] gesterzhou commented on a change in pull request #6036: GEODE-8856: Persist gateway-sender state

gesterzhou commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r602742538



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/InternalGatewaySender.java
##########
@@ -46,7 +46,7 @@
 
   void destroy(boolean initiator);
 
-  void setStartEventProcessorInPausedState();
+  void setStartEventProcessorInPausedState(boolean isPaused);

Review comment:
       so far this fix is a refactoring of current code to save the "paused" state into cache config. In that regard, this fix is good. 
   
   However, since we now have many states now and all these different states will be saved and persisted into cache config, we should not always only persist "paused" state and the method name should also be generic. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org