You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2011/10/19 22:31:12 UTC
[jira] [Created] (CASSANDRA-3386) Avoid lock contention in hint
rows
Avoid lock contention in hint rows
----------------------------------
Key: CASSANDRA-3386
URL: https://issues.apache.org/jira/browse/CASSANDRA-3386
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.7.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 0.8.8, 1.0.1
As pointed out by Yang in CASSANDRA-3385, hint writes are keyed by target IP, to make replay efficient. However, this means that we'll hit a lot of lock contention in table.apply where we synchronize for potential index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3386) Avoid lock contention in hint
rows
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131714#comment-13131714 ]
Hudson commented on CASSANDRA-3386:
-----------------------------------
Integrated in Cassandra-0.8 #383 (See [https://builds.apache.org/job/Cassandra-0.8/383/])
avoid locking on update when no indexes are involved
patch by jbellis; reviewed by slebrense for CASSANDRA-3386
jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186803
Files :
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/Table.java
> Avoid lock contention in hint rows
> ----------------------------------
>
> Key: CASSANDRA-3386
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3386
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.8.8, 1.0.1
>
> Attachments: 3386.txt
>
>
> As pointed out by Yang in CASSANDRA-3385, hint writes are keyed by target IP, to make replay efficient. However, this means that we'll hit a lot of lock contention in table.apply where we synchronize for potential index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3386) Avoid lock contention in hint
rows
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131552#comment-13131552 ]
Sylvain Lebresne commented on CASSANDRA-3386:
---------------------------------------------
Looks good to me though I haven't been able to apply the patch cleanly somehow, against what is it supposed to be ?
> Avoid lock contention in hint rows
> ----------------------------------
>
> Key: CASSANDRA-3386
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3386
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.8.8, 1.0.1
>
> Attachments: 3386.txt
>
>
> As pointed out by Yang in CASSANDRA-3385, hint writes are keyed by target IP, to make replay efficient. However, this means that we'll hit a lot of lock contention in table.apply where we synchronize for potential index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3386) Avoid lock contention in hint
rows
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131605#comment-13131605 ]
Sylvain Lebresne commented on CASSANDRA-3386:
---------------------------------------------
The 'not applying' part was mine. +1
> Avoid lock contention in hint rows
> ----------------------------------
>
> Key: CASSANDRA-3386
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3386
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.8.8, 1.0.1
>
> Attachments: 3386.txt
>
>
> As pointed out by Yang in CASSANDRA-3385, hint writes are keyed by target IP, to make replay efficient. However, this means that we'll hit a lot of lock contention in table.apply where we synchronize for potential index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3386) Avoid lock contention in hint
rows
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3386:
--------------------------------------
Attachment: 3386.txt
Patch skips the synchronization when there are no mutated index columns. (I'm 99% sure that's the only reason we need to lock there...)
> Avoid lock contention in hint rows
> ----------------------------------
>
> Key: CASSANDRA-3386
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3386
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.8.8, 1.0.1
>
> Attachments: 3386.txt
>
>
> As pointed out by Yang in CASSANDRA-3385, hint writes are keyed by target IP, to make replay efficient. However, this means that we'll hit a lot of lock contention in table.apply where we synchronize for potential index updates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira