[GitHub] [metamodel] kaspersorensen commented on a change in pull request #229: Upgrade to Elasticsearch 7.3.1

[GitBox <gi...@apache.org>]

kaspersorensen commented on a change in pull request #229: Upgrade to Elasticsearch 7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r327666371
 
 

 ##########
 File path: elasticsearch/native/src/main/java/org/apache/metamodel/elasticsearch/nativeclient/ElasticSearchDataContextFactory.java
 ##########
 @@ -131,10 +135,16 @@ public DataContext create(DataContextProperties properties, ResourceFactoryRegis
     }
 
     private Client createTransportClient(DataContextProperties properties) {
-        final Settings settings = Settings.builder().put().put("name", "MetaModel").put("cluster.name", getCluster(properties)).build();
+        final Settings settings = Settings
+                .builder()
+                .put("name", "MetaModel")
 
 Review comment:
   I've always wondered if this has any effect. Maybe we should make it a system property just in case someone wants to change it. Not a blocker for this PR though, just a thought.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services