[GitHub] [flink] slinkydeveloper commented on a change in pull request #18878: [FLINK-25971][table-planner] Hide JsonSerdeUtil#getObjectMapper

[GitBox <gi...@apache.org>]

slinkydeveloper commented on a change in pull request #18878:
URL: https://github.com/apache/flink/pull/18878#discussion_r818569136



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSerdeUtil.java
##########
@@ -103,8 +103,14 @@ public static boolean hasJsonCreatorAnnotation(Class<?> clazz) {
         OBJECT_MAPPER_INSTANCE.registerModule(createFlinkTableJacksonModule());
     }
 
-    /** Get the {@link ObjectMapper} instance. */
-    public static ObjectMapper getObjectMapper() {
+    /**
+     * Get the {@link ObjectMapper} instance.
+     *
+     * <p>This is not exposed outside this package to avoid bad usages, like adding new modules. If
+     * you need to read and write json, just use {@link #createObjectWriter(SerdeContext)} and
+     * {@link #createObjectReader(SerdeContext)}.
+     */
+    static ObjectMapper getObjectMapper() {

Review comment:
       I removed the method completely, check the last commit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org