You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by mehdidb <gi...@git.apache.org> on 2017/03/20 13:41:50 UTC

[GitHub] incubator-samoa pull request #57: Pull request

GitHub user mehdidb opened a pull request:

    https://github.com/apache/incubator-samoa/pull/57

    Pull request

    SAMOA-MOA Instances integration
    SAMOA-67 : Integration of MOA Instances into SAMOA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mehdidb/incubator-samoa master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-samoa/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 5264a9071d17160558d9fdfadd78bca1e352d9f5
Author: mehdidb <me...@supcom.tn>
Date:   2017-03-20T11:21:48Z

    First comit
    
    SAMOA-MOA Instances integration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-samoa pull request #57: Pull request

Posted by mehdidb <gi...@git.apache.org>.
Github user mehdidb closed the pull request at:

    https://github.com/apache/incubator-samoa/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-samoa issue #57: Pull request

Posted by nicolas-kourtellis <gi...@git.apache.org>.
Github user nicolas-kourtellis commented on the issue:

    https://github.com/apache/incubator-samoa/pull/57
  
    @abifet Can you please have a look at this and give us the OK?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-samoa pull request #57: Pull request

Posted by nicolas-kourtellis <gi...@git.apache.org>.
Github user nicolas-kourtellis commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/57#discussion_r123263827
  
    --- Diff: samoa-instances/src/main/java/org/apache/samoa/instances/AttributesInformation.java ---
    @@ -0,0 +1,175 @@
    +/*
    + * 
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + * 
    + * 	        http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
    + * either express or implied. See the License for the specific
    + * language governing permissions and limitations under the
    + * License.  
    + */
    +package org.apache.samoa.instances;
    +
    +/*
    + * #%L
    + * SAMOA
    + * %%
    + * Copyright (C) 2014 - 2017 Apache Software Foundation
    + * %%
    --- End diff --
    
    Can you please remove Copyright years all through the files modified? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---