You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/04 11:27:57 UTC

[GitHub] [flink] tsreaper commented on pull request #17672: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

tsreaper commented on pull request #17672:
URL: https://github.com/apache/flink/pull/17672#issuecomment-960675682


   Hi @Tartarus0zm , thanks for the commit.
   
   Although this is a very simple change, it would be better to add some tests reflecting such change both for validating and to prevent others from accidentally modifying it.
   
   I would suggest adding a test using filesystem connector and testcsv format in `TableSourceITCase`. Wrap the execution of SQL with a user code class loader (for how to create one, see usages of `ClientUtils#buildUserCodeClassLoader`). In the `eval` method of your your UDF check that its class loader is the desired one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org